Skip to content

Update nanostack-interface error mapping #10014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2019
Merged

Update nanostack-interface error mapping #10014

merged 1 commit into from
Mar 17, 2019

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Mar 8, 2019

Description

Use status NSAPI_ERROR_PARAMETER instead of NSAPI_ERROR_UNSUPPORTED
when error is caused by parameter mismatch.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

Update nanostack-interface error mapping
f0d7e20 
Use status NSAPI_ERROR_PARAMETER instead of NSAPI_ERROR_UNSUPPORTED
when error is caused by parameter.
@artokin artokin force-pushed the nanostack_interface_error_mapping branch from b6e94b4 to f0d7e20 Compare March 8, 2019 14:28
SeppoTakalo
SeppoTakalo suggested changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes.
These are still left returning UNSUPPORTED:

SeppoTakalo
SeppoTakalo approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good.

@ciarmcom ciarmcom requested review from SeppoTakalo and a team March 8, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 8, 2019

@artokin, thank you for your changes.
@SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Merge pull request ARMmbed#10014 from null
b2af369 
null
cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Merge pull request ARMmbed#10014 from artokin/nanostack_interface_err…
b9d91be 
…or_mapping

Update nanostack-interface error mapping
@cmonr cmonr merged commit b433b16 into ARMmbed:master Mar 17, 2019
@artokin artokin deleted the nanostack_interface_error_mapping branch March 18, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@artokin @ciarmcom @0xc0170 @mbed-ci @SeppoTakalo @cmonr