STM: Update linker script for using SRAM1 and SRAM2 in ARM #10018

deepikabhavnani · 2019-03-08T17:50:26Z

Description

To have the flexibilty in application; to use any of the section (data/bss/heap) without updating linker script in every use case, following decisions are made:

Fixed size and small sections moved to SRAM2 (32K)
Vectors
Crash data
Stack
Remaining section - RW / ZI
Large memory space should be used for variable sections
RW/ZI
Heap - (Minimum - xxx target based)

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

ciarmcom · 2019-03-08T18:00:29Z

@deepikabhavnani, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

jeromecoutant

Few questions.
But as a general question, not easy to approve a specific PR for 2 targets and 1 toolchain only
@LMESTM

TESTS/mbedmicro-rtos-mbed/heap_and_stack/main.cpp

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L443xC/device/TOOLCHAIN_ARM_STD/stm32l443xx.sct

targets/TARGET_STM/mbed_rtx.h

adbridge · 2019-03-27T16:27:17Z

@deepikabhavnani what is the status of this PR? It at least needs a rebase...

cmonr · 2019-03-27T22:06:36Z

Closing for now since @deepikabhavnani is out until 2nd week of April.

deepikabhavnani · 2019-04-09T15:52:39Z

@ARMmbed/mbed-os-maintainers - Can we please reopen this?

cmonr · 2019-04-09T16:28:49Z

@deepikabhavnani Done!

Looks like this needs a rebase.

deepikabhavnani · 2019-04-09T18:40:30Z

Rebased to resolve conflicts

To have the flexibilty in application; to use any of the section (data/bss/heap) without updating linker script in every use case, following decisions are made: 1. Fixed size and small sections moved to SRAM2 (32K) Vectors Crash data Remaining section - RW / ZI 2. Large memory space should be used for variable sections RW/ZI Heap - (Minimum - 0x12000) Stack - At bottom

deepikabhavnani · 2019-04-09T18:49:09Z

@jeromecoutant - Please review

jeromecoutant

I could approve, but who takes the action to align all scatter files of all targets...

deepikabhavnani · 2019-04-10T13:46:22Z

I could approve, but who takes the action to align all scatter files of all targets...

Aligning all scatter files for devices supporting multiple RAM bank is the query I suppose? Existing linker scripts work and are aligned to Mbed OS memory map but both RAM banks were not utilized. Linker scripts for Pelion platform/applications in need of more RAM were requested hence updating the ones in need now. Rest shall be updated as part of Pelion porting, or can also add issue in Mbed OS to keep track.

cmonr · 2019-04-12T01:49:16Z

CI started

mbed-ci · 2019-04-12T03:09:18Z

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

0xc0170 · 2019-04-12T09:08:03Z

heap and stack overlaps in the build logs - one target failures, please review

deepikabhavnani · 2019-04-12T20:30:14Z

heap and stack overlaps in the build logs - one target failures, please review

4b7e163 - shall fix this

0xc0170 · 2019-04-15T09:33:59Z

CI started

mbed-ci · 2019-04-15T16:40:07Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

deepikabhavnani · 2019-04-15T16:56:01Z

Failed test jobs:
jenkins-ci/mbed-os-ci_dynamic-memory-usage

Where can I find log for failing job?

alekla01 · 2019-04-15T18:59:07Z

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

deepikabhavnani · 2019-04-17T18:46:16Z

continuous-integration/jenkins/pr-head - Looks like same auto-trigger issue

0xc0170 · 2019-04-18T12:35:42Z

CI restarted

mbed-ci · 2019-04-18T15:22:41Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

deepikabhavnani · 2019-04-23T15:22:39Z

@ARMmbed/mbed-os-maintainers : Approved + CI is success

adbridge · 2019-04-25T15:17:30Z

ci started

mbed-ci · 2019-04-25T20:26:08Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 6
Build artifacts

deepikabhavnani mentioned this pull request Mar 8, 2019

stm32l475: lwip symbols in sram1 #9793

Closed

ciarmcom requested review from screamerbg and a team March 8, 2019 18:00

ciarmcom added the needs: review label Mar 8, 2019

deepikabhavnani force-pushed the stm32_heap_armc6 branch from 897a7d2 to ace2397 Compare March 8, 2019 20:42

jeromecoutant reviewed Mar 11, 2019

View reviewed changes

TESTS/mbedmicro-rtos-mbed/heap_and_stack/main.cpp Outdated Show resolved Hide resolved

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L443xC/device/TOOLCHAIN_ARM_STD/stm32l443xx.sct Show resolved Hide resolved

targets/TARGET_STM/mbed_rtx.h Show resolved Hide resolved

0xc0170 added needs: work and removed needs: review labels Mar 11, 2019

cmonr closed this Mar 27, 2019

cmonr removed the needs: work label Mar 27, 2019

cmonr reopened this Apr 9, 2019

cmonr added the needs: work label Apr 9, 2019

deepikabhavnani force-pushed the stm32_heap_armc6 branch from ace2397 to d5c3fc5 Compare April 9, 2019 18:39

deepikabhavnani force-pushed the stm32_heap_armc6 branch from d5c3fc5 to feba293 Compare April 9, 2019 18:48

cmonr added needs: review and removed needs: work labels Apr 9, 2019

jeromecoutant reviewed Apr 10, 2019

View reviewed changes

deepikabhavnani mentioned this pull request Apr 10, 2019

Align linker files for all targets having multiple RAM banks #10370

Closed

jeromecoutant approved these changes Apr 11, 2019

View reviewed changes

cmonr added needs: CI and removed needs: review labels Apr 12, 2019

cmonr approved these changes Apr 12, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: CI labels Apr 12, 2019

Add missing boot stack size memory from heap calculation

4b7e163

0xc0170 removed the request for review from screamerbg April 18, 2019 12:35

0xc0170 added needs: CI and removed needs: work labels Apr 18, 2019

adbridge added ready for merge release-version: 5.12.3 and removed needs: CI labels Apr 26, 2019

adbridge merged commit 536da47 into ARMmbed:master Apr 26, 2019

adbridge removed the ready for merge label Apr 26, 2019

STM: Update linker script for using SRAM1 and SRAM2 in ARM #10018

STM: Update linker script for using SRAM1 and SRAM2 in ARM #10018

Uh oh!

Conversation

deepikabhavnani commented Mar 8, 2019

Description

Pull request type

Uh oh!

ciarmcom commented Mar 8, 2019

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adbridge commented Mar 27, 2019

Uh oh!

cmonr commented Mar 27, 2019

Uh oh!

deepikabhavnani commented Apr 9, 2019

Uh oh!

cmonr commented Apr 9, 2019

Uh oh!

deepikabhavnani commented Apr 9, 2019

Uh oh!

deepikabhavnani commented Apr 9, 2019

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

deepikabhavnani commented Apr 10, 2019

Uh oh!

cmonr commented Apr 12, 2019

Uh oh!

mbed-ci commented Apr 12, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Apr 12, 2019

Uh oh!

deepikabhavnani commented Apr 12, 2019

Uh oh!

0xc0170 commented Apr 15, 2019

Uh oh!

mbed-ci commented Apr 15, 2019

Test run: FAILED

Uh oh!

deepikabhavnani commented Apr 15, 2019

Uh oh!

alekla01 commented Apr 15, 2019

Uh oh!

deepikabhavnani commented Apr 17, 2019

Uh oh!

0xc0170 commented Apr 18, 2019

Uh oh!

mbed-ci commented Apr 18, 2019

Test run: SUCCESS

Uh oh!

deepikabhavnani commented Apr 23, 2019

Uh oh!

adbridge commented Apr 25, 2019

Uh oh!

mbed-ci commented Apr 25, 2019

Test run: SUCCESS

Uh oh!

Uh oh!