Skip to content

uARM - Move heap region after IRAM1 #10019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

uARM - Move heap region after IRAM1 #10019

merged 1 commit into from
Apr 18, 2019

Conversation

deepikabhavnani
Copy link

Description

ARM_LIB_HEAP start is aligned to IRAM1 end, hence should be placed next to RW_IRAM1 i.e. no other region in between.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar, screamerbg and a team March 8, 2019 22:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 8, 2019

@deepikabhavnani, thank you for your changes.
@MarceloSalazar @screamerbg @maclobdell @ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested a review from a team March 27, 2019 21:46
@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

@MarceloSalazar @screamerbg @maclobdell Please review.

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

Closing for now since @deepikabhavnani is out until 2nd week of April.

@cmonr cmonr closed this Mar 27, 2019
@deepikabhavnani
Copy link
Author

@ARMmbed/mbed-os-maintainers - Can we please reopen this?

@cmonr cmonr reopened this Apr 9, 2019
@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

@deepikabhavnani Done!

@deepikabhavnani
Copy link
Author

@mmahadevan108 @jeromecoutant @maclobdell - Please review

uARM - Move heap region after IRAM1
36c7b2d 
ARM_LIB_HEAP start is aligned to IRAM1 end, hence should be placed next to
RW_IRAM1 i.e. no other region in between.
@deepikabhavnani
Copy link
Author

Rebased to re-trigger CI, and pick up latest fixes.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@alekla01
Copy link
Contributor

Restarted jenkins-ci

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Apr 11, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2019

@ARMmbed/team-nxp Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

We would like to proceed with this PR

@0xc0170 0xc0170 removed the request for review from screamerbg April 15, 2019 13:43
@deepikabhavnani
Copy link
Author

Was CI triggered accidentally on this PR again? Not sure why continuous-integration/jenkins/pr-head is X

@cmonr
Copy link
Contributor

cmonr commented Apr 16, 2019

@deepikabhavnani Something like that. I think @ARMmbed/mbed-os-test-team are working on CI auto-triggering.

The current config doesn't have a way to indicate that a job was aborted.

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 6
Build artifacts

@0xc0170 0xc0170 merged commit b6a2c7b into ARMmbed:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
release-version: 5.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deepikabhavnani @ciarmcom @cmonr @0xc0170 @mbed-ci @alekla01 @jeromecoutant