Skip to content

add vprintf to Rawserial. #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

add vprintf to Rawserial. #10043

merged 1 commit into from
Mar 28, 2019

Conversation

ithinuel
Copy link
Member

Description

Adds vprintf to RawSerial and make printf use it.
This methods enables using printf formatting in functions already using variadic arguments.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team March 12, 2019 00:00
@ciarmcom
Copy link
Member

@ithinuel, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from kjbracey March 13, 2019 10:38
kjbracey
kjbracey approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I dislike anyone using RawSerial, I dislike variadic functions without v counterparts even more, so this seems like an obvious extension.

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019
Merge pull request ARMmbed#10043 from ithinuel/add_vprintf_to_rawserial
694dfd8 
add vprintf to Rawserial.
@cmonr cmonr merged commit d7bec65 into ARMmbed:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ithinuel @ciarmcom @cmonr @mbed-ci @kjbracey