Skip to content

PSA: release.py bugfix - send the correct parameter to _get_target_info() #10046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019
Merged

PSA: release.py bugfix - send the correct parameter to _get_target_info() #10046

merged 1 commit into from
Mar 12, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 12, 2019

Description

  • send the correct parameter to _get_target_info()

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge

Release Notes

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2019

Sufficient to have in rc3?

@orenc17
Copy link
Contributor Author

orenc17 commented Mar 12, 2019

rc2... i'm sorry, the tool is already integrated into the mbed-os-release

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2019

@orenc17 is there anything else we should expect?

@orenc17
Copy link
Contributor Author

orenc17 commented Mar 12, 2019

(hopefully) no.

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

CI completed successfully , this is ready pending rc approval

@NirSonnenschein
Copy link
Contributor

@0xc0170 Neil has approved merge into rc2 for this one.

@0xc0170 0xc0170 merged commit 401a3c8 into ARMmbed:master Mar 12, 2019
@orenc17 orenc17 deleted the another_tool_fix branch March 12, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants