Cellular: Make CellularStateMachine timeouts configurable #10053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

0xc0170 merged 1 commit into ARMmbed:master from AriParkkila:cellular-state-timeout

Apr 15, 2019

AriParkkila commented Mar 12, 2019

Description

Make CellularStateMachine timeouts user configurable, as requested in #9735.

This change depends on PR #9937 (included so please review only the top commit).

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

ciarmcom requested review from jarvte and a team

March 12, 2019 12:00

Member

ciarmcom commented Mar 12, 2019

@AriParkkila, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

ciarmcom added the needs: review label

jarvte approved these changes

View reviewed changes

AnttiKauppila reviewed

View reviewed changes

features/cellular/framework/AT/AT_CellularNetwork.cpp Outdated Show resolved Hide resolved

AnttiKauppila reviewed

View reviewed changes

features/cellular/framework/device/CellularStateMachine.cpp Outdated Show resolved Hide resolved

AnttiKauppila reviewed

View reviewed changes

features/cellular/framework/device/CellularStateMachine.cpp Outdated Show resolved Hide resolved

AnttiKauppila reviewed

View reviewed changes

features/cellular/framework/device/CellularStateMachine.cpp Outdated Show resolved Hide resolved

AnttiKauppila reviewed

View reviewed changes

features/cellular/framework/device/CellularStateMachine.cpp Outdated Show resolved Hide resolved

AnttiKauppila reviewed

View reviewed changes

features/cellular/framework/device/CellularStateMachine.cpp Outdated Show resolved Hide resolved

AnttiKauppila suggested changes

View reviewed changes

AnttiKauppila left a comment

Those MACRO checks needs to be revisited

0xc0170 added needs: work and removed needs: review labels

AriParkkila force-pushed the cellular-state-timeout branch from 56955aa to acbf534 Compare

March 25, 2019 11:01

Author

AriParkkila commented Mar 25, 2019

Those MACRO checks needs to be revisited

@AnttiKauppila do you mean that this should be implemented without MACROs?

AriParkkila force-pushed the cellular-state-timeout branch from acbf534 to 22e193c Compare

April 3, 2019 10:32

Author

AriParkkila commented Apr 3, 2019

@jarvte @AnttiKauppila changed implementation so that is does not have MACROs.

0xc0170 added needs: review and removed needs: work labels

0xc0170 approved these changes

View reviewed changes

AnttiKauppila approved these changes

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels

Contributor

0xc0170 commented Apr 3, 2019

CI started

mbed-ci commented Apr 3, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests

jarvte suggested changes

View reviewed changes

features/cellular/framework/AT/AT_CellularContext.cpp Outdated Show resolved Hide resolved

features/cellular/framework/device/CellularContext.cpp Show resolved Hide resolved

features/cellular/framework/device/CellularStateMachine.h Outdated Show resolved Hide resolved

0xc0170 added needs: work and removed needs: CI labels

AriParkkila force-pushed the cellular-state-timeout branch from 22e193c to 4d28684 Compare

April 4, 2019 06:19

Author

AriParkkila commented Apr 4, 2019

@jarvte please re-review

jarvte approved these changes

View reviewed changes

jarvte mentioned this pull request

CellularStateMachine can generate spurious attach events #9737

Closed

AriParkkila mentioned this pull request

ATHandler set/restore at_timeout needs lock #9735

Closed

0xc0170 added needs: CI and removed needs: work labels

Contributor

0xc0170 commented Apr 4, 2019

CI started

mbed-ci commented Apr 5, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_exporter
jenkins-ci/mbed-os-ci_cloud-client-test

Contributor

alekla01 commented Apr 5, 2019

restarted CI

mbed-ci commented Apr 5, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

0xc0170 added ready for merge release-version: 5.13.0-rc1 and removed needs: CI labels

cmonr added needs: work and removed ready for merge labels

Contributor

cmonr commented Apr 9, 2019

@AriParkkila This will need a rebase.


          Cellular: Fix CellularStateMachine timeout configurations

e0f8b21

AriParkkila force-pushed the cellular-state-timeout branch from 4d28684 to e0f8b21 Compare

April 10, 2019 05:03

Author

AriParkkila commented Apr 10, 2019

@cmonr this is now rebased and ready for merge.

0xc0170 added needs: CI and removed needs: work labels

Contributor

0xc0170 commented Apr 10, 2019

CI started

mbed-ci commented Apr 10, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

Contributor

0xc0170 commented Apr 10, 2019

Exporter restarted

Contributor

cmonr commented Apr 12, 2019

CI job restarted: jenkins-ci/exporter

It's possible this PR might need a full rebuild. Something about the job being in a weird build state.

0xc0170 added ready for merge and removed needs: CI labels

0xc0170 merged commit 4401d41 into ARMmbed:master

0xc0170 removed the ready for merge label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 5.13.0-rc1