Add bootloader support for Cypress PSA boards #10055

yossi2le · 2019-03-12T12:22:17Z

Description

This PR adds bootloader support for the CY8CKIT_062_WIFI_BT_PSA and CY8CKIT_062_BLE boards in mbed-os.

This PR now depends on PR #10034 - V

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

0xc0170 · 2019-03-12T12:32:45Z

Release target?

I dont think this is functionality change, rather target update?

cmonr · 2019-03-12T13:25:41Z

Took a 10s lookover.

All of the files are PSOC-specific, thus this qualifies as a target update (aka, can come into a patch).

Release label udpated.

amiraloosh · 2019-03-12T13:30:58Z

This is required for the 5.12 release for the PSA support on the cypress board. can we target this to RC3 ?

0xc0170 · 2019-03-12T13:56:50Z

Fixed the title

yossi2le · 2019-03-12T15:02:50Z

I have added another 2 linker script for the CY8CKIT_062_WIFI_BT_PSA target. Those two works great with default values but needed a fix for nondefault values.

orenc17

Please add remarks in linker script for MBED_APP_START & MBED_APP_SIZE.
@ARMmbed/team-cypress please review changes in:

gpio_api.c,
serial_api.c
post-binary hook

Everything else looks OK

..._BOOTLOADER/targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_062_WIFI_BT_PSA/mbed_lib.json

0xc0170 · 2019-03-13T15:05:12Z

@orenc17 Does this need an additional review after recent changes?

orenc17 · 2019-03-13T15:06:18Z

No...just from Cypress

0xc0170 · 2019-03-13T15:20:51Z

CI started while waiting for final reviews

mbed-ci · 2019-03-13T17:33:12Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

csd-cypress · 2019-03-13T17:41:37Z

Hi,
We are not aware of this, and we are pursuing similar goals inside Cypress to enable bootloader support. As a first step do you have any design description so that we can compare your goals and approach to ours?

orenc17 · 2019-03-13T18:09:30Z

@ARMmbed/mbed-os-maintainers the failure seems to be related to SD, maybe a faulty SD card, could you run it again

orenc17 · 2019-03-13T18:11:23Z

@csd-cypress this is the inital support for pelion bootloader, to allow FW upgrade for the application core.
your HW bootloader will be integrated in the near future.

vmedcy · 2019-03-13T12:50:54Z

.../FEATURE_BOOTLOADER/targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_062_BLE/mbed_lib.json

+    "name": "bootloader_CY8CKIT_062_BLE",
+    "target_overrides": {
+        "*": {
+            "target.app_offset": "0x0A400",


Why these target attributes are added to mbed_lib.json instead of top-level targets.json?

this is a bootloader property.
if a user decide not to use bootloader we don't need this config

vmedcy · 2019-03-13T12:53:00Z

features/FEATURE_BOOTLOADER/targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_062_BLE/LICENSE

@@ -0,0 +1,49 @@
+Permissive Binary License


Why the LICENSE is added to top-level target directory? The PBL only applies to the hex files, not .c/.h sources.
Can you move the hex files to device/hex, together with existing hex files covered by binary license?

Sorry I just figured out this is features/FEATURE_BOOTLOADER/targets/TARGET_Cypress, not targets/TARGET_Cypress.

targets/targets.json

tools/arm_pack_manager/index.json

targets/targets.json

csd-cypress · 2019-03-13T18:42:59Z

@csd-cypress this is the inital support for pelion bootloader, to allow FW upgrade for the application core.
your HW bootloader will be integrated in the near future.

ok understood, it will still be good to understand more about the pelion bootloader so that we can integrate it to our bootloader effort. Is it mcuboot based? Do you expect it to come after/before/in-replacement of our bootloader? How will it integrate verification of signed images with the PSoC64 root-of-trust?
Also when you say HW bootloader will be integrated in the near future - which HW bootloader and integrated by whom?

yossi2le · 2019-03-14T10:54:22Z

Important update: After the last update, this PR now depends on PR #10034

…CY8CKIT_062_BLE

…6/TARGET_CY8CKIT_062_WIFI_BT_PSA/mbed_lib.json Co-Authored-By: yossi2le <[email protected]>

…Y8C62XX and TARGET_CY8CKIT_062_BLE linker scripts

…PSA index.json file

yossi2le · 2019-03-14T12:28:42Z

Rebase on top of master with all preceding PRs merged.
Please start CI

0xc0170 · 2019-03-14T12:31:31Z

CI started

yossi2le · 2019-03-14T14:15:12Z

@csd-cypress this is the inital support for pelion bootloader, to allow FW upgrade for the application core.
your HW bootloader will be integrated in the near future.

ok understood, it will still be good to understand more about the pelion bootloader so that we can integrate it to our bootloader effort. Is it mcuboot based? Do you expect it to come after/before/in-replacement of our bootloader? How will it integrate verification of signed images with the PSoC64 root-of-trust?
Also when you say HW bootloader will be integrated in the near future - which HW bootloader and integrated by whom?

You can find our bootloader sources and some docs at https://github.com/ARMmbed/mbed-bootloader-internal

0xc0170 · 2019-03-14T14:25:04Z

@yossi2le Above url is internal, not available publicly

yossi2le · 2019-03-14T14:36:14Z

@yossi2le Above url is internal, not available publicly

I didn't know that. do we have a link for a bootloader external? otherwise, I should delete my replay.

mbed-ci · 2019-03-14T18:05:52Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

cmonr added the release-version: 5.12.1 label Mar 12, 2019

0xc0170 added release-version: 5.12.0-rc3 and removed release-version: 5.12.1 labels Mar 12, 2019

0xc0170 requested review from a user March 12, 2019 13:33

0xc0170 added the needs: review label Mar 12, 2019

0xc0170 approved these changes Mar 12, 2019

View reviewed changes

0xc0170 changed the title ~~Mbed-os changes to support Cypress PSA boards bootloader.~~ Add bootloader support for Cypress PSA boards Mar 12, 2019

yossi2le force-pushed the cypress-psa-and-future-sequana-bl-support branch from d90defd to 7156568 Compare March 12, 2019 15:01

0xc0170 requested a review from a team March 13, 2019 10:37

orenc17 approved these changes Mar 13, 2019

View reviewed changes

..._BOOTLOADER/targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_062_WIFI_BT_PSA/mbed_lib.json Outdated Show resolved Hide resolved

0xc0170 added needs: CI and removed needs: review labels Mar 13, 2019

vmedcy reviewed Mar 13, 2019

View reviewed changes

orenc17 suggested changes Mar 13, 2019

View reviewed changes

tools/arm_pack_manager/index.json Show resolved Hide resolved

tools/arm_pack_manager/index.json Show resolved Hide resolved

targets/targets.json Outdated Show resolved Hide resolved

targets/targets.json Outdated Show resolved Hide resolved

cmonr mentioned this pull request Mar 13, 2019

PSA: PSoc 6 configurable secure memory size #10034

Merged

cmonr added the needs: work label Mar 13, 2019

cmonr removed the needs: CI label Mar 13, 2019

yossi2le force-pushed the cypress-psa-and-future-sequana-bl-support branch from c76a2e0 to eae884d Compare March 14, 2019 10:32

0xc0170 added the needs: preceding PR label Mar 14, 2019

yossi2le force-pushed the cypress-psa-and-future-sequana-bl-support branch from 266ac1f to e7d6d7a Compare March 14, 2019 12:05

Yossi Levy and others added 6 commits March 14, 2019 14:26

mbed-os to support bootlader for Cypress CY8CKIT_062_WIFI_BT_PSA and …

dd27a34

…CY8CKIT_062_BLE

Update features/FEATURE_BOOTLOADER/targets/TARGET_Cypress/TARGET_PSOC…

2fd7dc9

…6/TARGET_CY8CKIT_062_WIFI_BT_PSA/mbed_lib.json Co-Authored-By: yossi2le <[email protected]>

Adding documentation for MBED_APP_START and MBED_APP_SIZE in TARGET_C…

0a5b355

…Y8C62XX and TARGET_CY8CKIT_062_BLE linker scripts

Updating Cypress CY8CKIT_062_WIFI_BT_PSA and CY8CKIT_062_BLE device name

b401e99

Updating address of secure and non secure rom in CY8CKIT_062_WIFI_BT_…

2c400b6

…PSA index.json file

Updating CY8CKIT_062_WIFI_BT_PSA bootloader image

0880f90

yossi2le force-pushed the cypress-psa-and-future-sequana-bl-support branch from e7d6d7a to 0880f90 Compare March 14, 2019 12:27

0xc0170 added needs: CI and removed needs: preceding PR needs: work labels Mar 14, 2019

cmonr merged commit 529aef9 into ARMmbed:master Mar 14, 2019

cmonr removed the needs: CI label Mar 14, 2019

Add bootloader support for Cypress PSA boards #10055

Add bootloader support for Cypress PSA boards #10055

Uh oh!

Conversation

yossi2le commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

0xc0170 commented Mar 12, 2019

Uh oh!

cmonr commented Mar 12, 2019

Uh oh!

amiraloosh commented Mar 12, 2019

Uh oh!

0xc0170 commented Mar 12, 2019

Uh oh!

yossi2le commented Mar 12, 2019

Uh oh!

orenc17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xc0170 commented Mar 13, 2019

Uh oh!

orenc17 commented Mar 13, 2019

Uh oh!

0xc0170 commented Mar 13, 2019

Uh oh!

mbed-ci commented Mar 13, 2019

Test run: FAILED

Uh oh!

csd-cypress commented Mar 13, 2019

Uh oh!

orenc17 commented Mar 13, 2019

Uh oh!

orenc17 commented Mar 13, 2019

Uh oh!

vmedcy Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

orenc17 Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

vmedcy Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

vmedcy Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csd-cypress commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yossi2le commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yossi2le commented Mar 14, 2019

Uh oh!

0xc0170 commented Mar 14, 2019

Uh oh!

yossi2le commented Mar 14, 2019

Uh oh!

0xc0170 commented Mar 14, 2019

Uh oh!

yossi2le commented Mar 14, 2019

Uh oh!

mbed-ci commented Mar 14, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

yossi2le commented Mar 12, 2019 •

edited

Loading

csd-cypress commented Mar 13, 2019 •

edited

Loading

yossi2le commented Mar 14, 2019 •

edited

Loading