-
Notifications
You must be signed in to change notification settings - Fork 3k
Correct post-build-hook detection logic #10065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct post-build-hook detection logic #10065
Conversation
@theotherjimmy, thank you for your changes. |
@cmonr Does travis need a restart? |
Travis restarted |
Tested and I can confirm that this fixes both MTS_MDOT_F411RE and MTB_MTS_DRAGONFLY issues, thanks Jimmy. |
CI started |
Test run: FAILEDSummary: 1 of 9 test jobs failed Failed test jobs:
|
CI aborted, will be restarted after rc3 jobs |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
…trictions Correct post-build-hook detection logic
Description
Fixes #10032
The problem was that post build hook detection logic expected two things:
Neither of these assupmtions are correct.
I changed the logic to take in a list of toolchain labels, and delegated
the creating of toolchain labels to the toolchain. Then I cleaned up all
the pylint warnings.
Pull request type