Skip to content

Correct post-build-hook detection logic #10065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2019

Conversation

theotherjimmy
Copy link
Contributor

Description

Fixes #10032

The problem was that post build hook detection logic expected two things:

  • The toolchain argument was a toolchain object
  • That it could recreate toolchain labels itself

Neither of these assupmtions are correct.

I changed the logic to take in a list of toolchain labels, and delegated
the creating of toolchain labels to the toolchain. Then I cleaned up all
the pylint warnings.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team March 12, 2019 18:00
@ciarmcom
Copy link
Member

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@theotherjimmy
Copy link
Contributor Author

@cmonr Does travis need a restart?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 13, 2019

@cmonr Does travis need a restart?

Travis restarted

@kimlep01
Copy link

Tested and I can confirm that this fixes both MTS_MDOT_F411RE and MTB_MTS_DRAGONFLY issues, thanks Jimmy.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 14, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

CI aborted, will be restarted after rc3 jobs

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
…trictions

Correct post-build-hook detection logic
@cmonr cmonr merged commit 241e6d2 into ARMmbed:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants