PSA more options in release tool #10070

orenc17 · 2019-03-12T19:52:50Z

Description

Added logging infrastructure.
Added -v for verbose
Added --skip-tests to build only the main image.
Added -l to list PSA platforms.
Added -x to send extra argument to the build command such as -D

Note to maintainers: this is for 5.12.1

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

ciarmcom · 2019-03-12T20:00:46Z

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

theotherjimmy

Nothing looks out of the ordinary here.

orenc17 · 2019-03-12T22:31:24Z

@ARMmbed/mbed-os-maintainers do not merge yet
I still need to update docs and maybe more features

0xc0170 · 2019-03-13T09:42:41Z

@cmonr your review is very much a must here !

orenc17 · 2019-03-20T13:20:41Z

Finished with the changes.. ready for CI

cmonr

LGTM!

cmonr · 2019-03-20T18:30:04Z

tools/psa/release.py


    subprocess.check_call([
-        sys.executable, MAKE_PY_LOCATTION,
+        'mbed', 'test', '--compile',


cmonr · 2019-03-20T18:34:19Z

CI started

mbed-ci · 2019-03-20T20:53:42Z

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARMC6

cmonr · 2019-03-20T21:19:03Z

CI restarted.

Confirming PR has issues, since build failures seemed odd.

cmonr · 2019-03-20T21:54:51Z

CI restarted.

mbed-ci · 2019-03-20T22:34:33Z

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARMC6

cmonr · 2019-03-20T22:53:19Z

CI started

mbed-ci · 2019-03-20T23:37:38Z

Test run: FAILED

Summary: 7 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_mbed2-build-IAR8
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC6

mbed-ci · 2019-03-21T00:45:24Z

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC6

orenc17 · 2019-03-21T08:40:12Z

@ARMmbed/mbed-os-maintainers can you run again? i've reverted back parts of the implementation to the previous one

0xc0170 · 2019-03-21T10:23:14Z

CI was restarted

adbridge · 2019-03-21T14:12:18Z

@oren will there be additional changes required to the mbed-os release script to use some of these new options ?

adbridge

AFAICT looks ok

orenc17 · 2019-03-21T14:26:34Z

@oren will there be additional changes required to the mbed-os release script to use some of these new options ?

this PR will make the PSA script verbose, if you want to disable most of the prints we'll need to add -q to mbed-os release script

orenc17 · 2019-03-25T12:01:10Z

@adbridge the new -x feature is tested with the psa-compliance example repo

tools/psa/release.py

* Default verbose * -q for quiet build with minimal status prints

* Use default image command generator. * Call directly to mbed-cli. * Add --skip-tests.

NirSonnenschein · 2019-03-26T08:58:00Z

Starting CI

mbed-ci · 2019-03-26T10:02:50Z

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC6

cmonr · 2019-03-26T16:37:08Z

Will start CI for now, but the last commit points to something interesting.

@orenc17 What kind of local testing was done prior to the PR?

cmonr · 2019-03-26T16:37:19Z

CI started

orenc17 · 2019-03-26T16:49:54Z

@cmonr i tried to implement the extra parameter with and without a leading symbol (-x in my case).
when i didn't define the leading symbol i always got an empty array when no extra params were sent.
when i did define the leading symbol i got a None when no extra params were sent.
that is why i needed to add default=[] in the last commit

PSA more options in release tool

mbed-ci · 2019-03-26T21:09:55Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

cmonr · 2019-03-26T21:29:30Z

CI job restarted: jenkins-ci/dynamic-memory-usage

Dunno why this failed with this PR to begin with.

| GCC_ARM-K66F | K66F | ethernet | TIMEOUT | 92.05 | default |

ciarmcom requested review from a team March 12, 2019 20:00

ciarmcom added the needs: review label Mar 12, 2019

theotherjimmy approved these changes Mar 12, 2019

View reviewed changes

orenc17 changed the title ~~[PSA] more options in release tool~~ [PSA] more options in release tool - WIP Mar 12, 2019

0xc0170 changed the title ~~[PSA] more options in release tool - WIP~~ PSA more options in release tool - WIP Mar 13, 2019

0xc0170 added release-version: 5.12.1 needs: work and removed needs: review labels Mar 13, 2019

cmonr self-requested a review March 13, 2019 20:12

orenc17 changed the title ~~PSA more options in release tool - WIP~~ PSA more options in release tool Mar 20, 2019

0xc0170 added needs: review and removed needs: work labels Mar 20, 2019

cmonr approved these changes Mar 20, 2019

View reviewed changes

tools/psa/release.py Outdated

subprocess.check_call([

sys.executable, MAKE_PY_LOCATTION,

'mbed', 'test', '--compile',

Copy link

Contributor

cmonr Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

cmonr added needs: CI and removed needs: review labels Mar 20, 2019

adbridge approved these changes Mar 21, 2019

View reviewed changes

cmonr reviewed Mar 25, 2019

View reviewed changes

tools/psa/release.py Show resolved Hide resolved

cmonr reviewed Mar 25, 2019

View reviewed changes

tools/psa/release.py Show resolved Hide resolved

Oren Cohen and others added 9 commits March 26, 2019 10:48

Overhaul logging and verbosity

10708f1

* Default verbose * -q for quiet build with minimal status prints

List PSA secure platform and add choices option

16bcd5f

Refactor

6548824

* Use default image command generator. * Call directly to mbed-cli. * Add --skip-tests.

Docs update

aa21d36

Add list option

03c0302

small fix

e8165fd

Revert back to direct calls to python

ef19ade

Specify extra args with -x and verbose_check_call

6d64c85

Missing docstring

d012b3a

NirSonnenschein added needs: CI and removed needs: review labels Mar 26, 2019

Set default value of extra args to []

42a9d48

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10070 from kfnta/tool_options

8279b78

PSA more options in release tool

cmonr added ready for merge and removed needs: CI labels Mar 27, 2019

cmonr merged commit 7e7f4f5 into ARMmbed:master Mar 27, 2019

cmonr removed the ready for merge label Mar 27, 2019

PSA more options in release tool #10070

PSA more options in release tool #10070

Uh oh!

Conversation

orenc17 commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Mar 12, 2019

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Mar 12, 2019

Uh oh!

0xc0170 commented Mar 13, 2019

Uh oh!

orenc17 commented Mar 20, 2019

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr Mar 20, 2019

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

mbed-ci commented Mar 20, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

mbed-ci commented Mar 20, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

mbed-ci commented Mar 20, 2019

Test run: FAILED

Uh oh!

mbed-ci commented Mar 21, 2019

Test run: FAILED

Uh oh!

orenc17 commented Mar 21, 2019

Uh oh!

0xc0170 commented Mar 21, 2019

Uh oh!

adbridge commented Mar 21, 2019

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Mar 21, 2019

Uh oh!

orenc17 commented Mar 25, 2019

Uh oh!

Uh oh!

Uh oh!

NirSonnenschein commented Mar 26, 2019

Uh oh!

mbed-ci commented Mar 26, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 26, 2019

Uh oh!

cmonr commented Mar 26, 2019

Uh oh!

orenc17 commented Mar 26, 2019

Uh oh!

mbed-ci commented Mar 26, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 26, 2019

Uh oh!

Uh oh!

orenc17 commented Mar 12, 2019 •

edited

Loading