Adding variable length attributes to Maxim Feather #10072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nick-atmosphereiot, thank you for your changes. |
0xc0170
reviewed
Mar 13, 2019
| @@ -146,6 +146,12 @@ ble_error_t MaximGattServer::addService_(GattService &service) | |||
| currAtt->pLen = p_char->getValueAttribute().getLengthPtr(); | |||
| currAtt->maxLen = p_char->getValueAttribute().getMaxLength(); | |||
| currAtt->settings = ATTS_SET_WRITE_CBACK | ATTS_SET_READ_CBACK; | |||
|
|
|||
| if(p_char->getValueAttribute().hasVariableLength()) | |||
| { | |||
There was a problem hiding this comment.
should follow the style in this file { on the same line as if
There was a problem hiding this comment.
@0xc0170 Good catch, fixed. :)
|
@Team-MaximIntegrated @ARMmbed/mbed-os-pan Thoughts? |
cmonr
approved these changes
Mar 27, 2019
pan-
approved these changes
Mar 28, 2019
|
Looks good to me |
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Max Feather board does not currently handle variable length attributes. With the released version of mbed-os, all attribute writes that are not maxLen are ignored.
This fix is tested locally with a MAX32630Fthr board using the BLE Scanner Android App to manually write attributes.
Pull request type