Skip to content

Make the presence of cmsis-pack-manager package optional #10089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

bridadan
Copy link
Contributor

Description

Currently, the 5.12.0 release candidates do not build in 0.4.0 Mbed Studio. This patch will allow you to use the "active program tools" in 5.12.0 projects to build correctly. The issue is that Mbed Studio has limited Python environment that does not contain the cmsis-pack-manager Python package. Since we can't install this at this time for Mbed Studio, this make the package optional so you can still compile and use the local CMSIS Pack index.

FYI @SenRamakri @thegecko

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@bridadan bridadan requested a review from theotherjimmy March 13, 2019 22:34
@theotherjimmy
Copy link
Contributor

@arekzaluski Do you need this change for Studio?

@bridadan
Copy link
Contributor Author

@theotherjimmy thanks for bringing @arekzaluski into the loop.

Yeah if at all possible, this should be in the final release candidate for 5.12.0 if the current version of Mbed Studion (0.4.0) is to have any way of using 5.12.0.

@cmonr
Copy link
Contributor

cmonr commented Mar 14, 2019

Currently, the 5.12.0 release candidates do not build in 0.4.0 Mbed Studio.

That's unfortunate, but a pretty good reason to get this into RC3.

@cmonr
Copy link
Contributor

cmonr commented Mar 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 14, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

The issue is that Mbed Studio has limited Python environment that does not contain the cmsis-pack-manager Python package. Since we can't install this at this time for Mbed Studio, this make the package optional so you can still compile and use the local CMSIS Pack index.

Does that mean the next studio version will contain a fix for this ?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

@arekzaluski Do you need this change for Studio?

Please let us know. This can go to master at least now

@0xc0170 0xc0170 merged commit 0f2add7 into ARMmbed:master Mar 14, 2019
@arekzaluski
Copy link
Contributor

@0xc0170 @bridadan @theotherjimmy Yes we need it, we will test it today in Mbed Studio. Thanks @bridadan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants