Skip to content

BLE:Fix cordio reset sequence #10093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

desmond-blue
Copy link
Contributor

Description

With this commit on this code line, Cordio reset sequence won't get done.
The handling case for HCI_OPCODE_LE_WRITE_DEF_DATA_LEN should send HciReadLocalVerInfoCmd().

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team March 14, 2019 10:00
@ciarmcom
Copy link
Member

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, run into same with new cordio (paul-szczepanek-arm@b96c0ac). I think this old one works because extended reset isn't run.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit a70f0e6 into ARMmbed:master Mar 15, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants