Skip to content

Cinterion Cellular: Setup connection profile with username and password #10098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

ghseb
Copy link

@ghseb ghseb commented Mar 14, 2019

Description

According to the documentation Cinterion Modules like the ELS61 additionally to the APN require a username and a password to setup the Connection Profile.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team March 14, 2019 12:00
@ciarmcom
Copy link
Member

@ghseb, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2019

@ARMmbed/mbed-os-maintainers I'm willing to consider tis as a fix.

Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine for default authentication. I'm guessing that authentication type (CHAP, PAP, ...) may need to be configurable sometimes, but it can be added when that's needed.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

@ARMmbed/mbed-os-maintainers I'm willing to consider tis as a fix.

It's target fix, LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2019

armclang: error: Failed to check out a license.

CI job restarted: jenkins-ci/exporter

@0xc0170 0xc0170 merged commit 964f5ad into ARMmbed:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants