Cellular: Support Cinterion EHS5-E cellular module #10100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghseb, thank you for your changes. |
You're good. |
AriParkkila
suggested changes
Mar 15, 2019
| { | ||
| // EHS5-E | ||
| static const intptr_t cellular_properties[AT_CellularBase::PROPERTY_MAX] = { | ||
| AT_CellularNetwork::RegistrationModeDisable, // C_GREG |
There was a problem hiding this comment.
This should probably be like below due to EHS5-E seems to be:
- 2G/3G modem
- With support for IPv4 and IPv6 but not for dual-stack
AT_CellularNetwork::RegistrationModeDisable, // C_EREG
AT_CellularNetwork::RegistrationModeLAC, // C_GREG
AT_CellularNetwork::RegistrationModeLAC, // C_REG
...
1, // PROPERTY_IPV4_STACK
1, // PROPERTY_IPV6_STACK
0, // PROPERTY_IPV4V6_STACK
There was a problem hiding this comment.
You are right the registration modes need to be fixed. But i think the module does support dual stack mode
There was a problem hiding this comment.
About dual-stack, according to ehs5-e_atc_v03001.pdf connection must be GPRS0 or GPRS6 and the current driver creates only one internet connection so it can't handle dual-stack yet.
AriParkkila
approved these changes
Mar 15, 2019
0xc0170
approved these changes
Mar 15, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 16, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 16, 2019
Cellular: Support Cinterion EHS5-E cellular module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add basic support for the Cinterion EHS5-E cellular module.
Im not sure if i categorized the PR correctly.
Pull request type
Reviewers
Release Notes