Skip to content

Update manifest tool to version 1.4.8 and install it from pypi #10106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Update manifest tool to version 1.4.8 and install it from pypi #10106

merged 1 commit into from
Mar 15, 2019

Conversation

arekzaluski
Copy link
Contributor

Description

Update manifest tool to latest version and install it from pypi.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[x] Breaking change

Reviewers

@evedon @bremoran @theotherjimmy @adbridge @bridadan

Release Notes

  • Update manifest-tool to version 1.4.8

@thegecko

@ciarmcom
Copy link
Member

@arekzaluski, thank you for your changes.
@thegecko @evedon @bremoran @theotherjimmy @bridadan @adbridge @ARMmbed/mbed-os-maintainers please review.

thegecko
thegecko approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmonr
cmonr approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

bremoran
bremoran approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@bremoran bremoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last!
LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d6088e5 into ARMmbed:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegecko thegecko thegecko approved these changes

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@bremoran bremoran bremoran approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge Awaiting requested review from adbridge

@bridadan bridadan Awaiting requested review from bridadan

@evedon evedon Awaiting requested review from evedon

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@arekzaluski @ciarmcom @0xc0170 @mbed-ci @thegecko @cmonr @theotherjimmy @bremoran