Use secure/non-secure rom for bl modes #10113
Conversation
To managed bootloader mode
|
@dannybenor You asked offline for this. Could you give feedback on if this works for you? |
theotherjimmy
force-pushed
the
use-ns-rom-in-bl
branch
from
3d8451b to
e798276
Compare
|
Note for maintainers: the first commit cleans up all the lint warnings in the config system, so if you're only looking for the functionality change, look at the 3rd commit. |
|
@theotherjimmy, thank you for your changes. |
Waiting (making a note here) |
| if hasattr(self.target, "mbed_rom_start"): | ||
| mem_start = getattr(self.target, "mbed_rom_start") | ||
| if hasattr(self.target, "mbed_rom_size"): | ||
| mem_size = getattr(self.target, "mbed_rom_size") |
There was a problem hiding this comment.
Should this section be using the same config object (the return value from get_config_data()) as the PSA section below?
There was a problem hiding this comment.
Talked offline with @theotherjimmy : PSA target memory config (ex (non-)secure-rom-start and (non-)secure-rom-size) actually uses the config system, where normal targets use "target data", hence the different way to access the data.
|
PSA targets already get the RAM defines injected to the linker |
|
Bumping to RC3 since this is needed for another PR. |
There was a problem hiding this comment.
Talked offline with @theotherjimmy: Sounds like RAM is not needed immediately for bootloader mode, so it was limited to ROM. There's no reason why RAM can't follow this PR as well.
LGTM
| if hasattr(self.target, "mbed_rom_start"): | ||
| mem_start = getattr(self.target, "mbed_rom_start") | ||
| if hasattr(self.target, "mbed_rom_size"): | ||
| mem_size = getattr(self.target, "mbed_rom_size") |
There was a problem hiding this comment.
Talked offline with @theotherjimmy : PSA target memory config (ex (non-)secure-rom-start and (non-)secure-rom-size) actually uses the config system, where normal targets use "target data", hence the different way to access the data.
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
Previously, a porter or application author could configure
secure or non-secure rom through the use of:
target.secure-rom-starttarget.secure-rom-sizetarget.non-secure-rom-starttarget.non-secure-rom-sizeThis allows them to configure this once, and have the same
values for both a secure build and a non-secure build.
This was not used by the bootloader modes and combining
these with either bootloader mode would lead to problems and
heartbreak.
This PR mends these broken hearts by heeding the secure and
non secure start and size in the bootloder modes.
Pull request type