Allow the use of Mbed Studio's version of ARMC6 #10114

bridadan · 2019-03-14T23:21:26Z

Description

This seems to be in good working order so far. I need to add a unit test before this is ready to go, hence raising this as a Draft pull request. Raising this early for coordination efforts and to get reviews started.

This allows people to use the ARMC6 compiler bundled with Mbed Studio with the command line tools. It also preserves the ability to use the professional compiler and license server.

FYI @ChiefBureaucraticOfficer @SenRamakri @arekzaluski @thegecko

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

You can use the ARMC6 compiler that is bundled with Mbed Studio with the command line tools. Enable this behavior by adding the ARMC6 executable to your system path (the default location of this on Windows is C:/MbedStudio/tools/ac6/bin). Alternatively, you can set this same location with Mbed CLI with the command mbed config ARMC6_PATH C:/MbedStudio/tools/ac6/bin (be sure to use the correct path when you run the command). You will also need to set the ARMLMD_LICENSE_FILE environment variable to the license file that is bundled with Mbed Studio. Check the Mbed OS documentation for further details.

theotherjimmy · 2019-03-14T23:42:48Z

@arekzaluski This should allow you to remove one of your patches.

ciarmcom · 2019-03-15T00:00:30Z

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

cmonr · 2019-03-15T00:07:21Z

raising this as a Draft pull request.

Look at you, using new GitHub features.

fancy

cmonr · 2019-03-15T02:38:04Z

CI started to get some information

mbed-ci · 2019-03-15T03:10:04Z

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6

cmonr · 2019-03-15T03:26:58Z

AttributeError: 'ARMC6' object has no attribute 'version_name'
'ARMC6' object has no attribute 'version_name'

bulislaw · 2019-03-15T14:46:55Z

Was that tested both on Windows and OSX?

bridadan · 2019-03-15T14:50:31Z

@bulislaw I don't have a machine running OSX, so I'll happily take any help there! Though I need to fix the error found here first.

bridadan · 2019-03-15T16:00:22Z

I was able to reproduce the issue shown in CI, the most recent patches should fix those.

0xc0170 · 2019-03-15T16:28:56Z

Will restart once travis tools are green, please review

bridadan · 2019-03-15T16:32:16Z

I'm working on a few local errors as well, thanks for keeping an eye on this.

bridadan · 2019-03-15T19:48:16Z

Ok I've tested this locally fairly extensively on Windows with the following compilers:

ARMC5
- From Keil uvision
- Professional compiler
ARMC6
- From Keil uvision
- Professional compiler
- From Mbed Studio

And all seem happy!

bridadan · 2019-03-15T20:03:10Z

Found a Mac and tested it, seemed to work just fine @bulislaw

0xc0170 · 2019-03-15T20:11:59Z

CI started

mbed-ci · 2019-03-15T22:51:36Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

0xc0170 · 2019-03-16T05:17:31Z

cc @mbed-os-test ^^

We will restart exporters later today

0xc0170 · 2019-03-16T05:17:43Z

Reviews are opened!

0xc0170 · 2019-03-16T05:24:43Z

exporters restarted

This enables the use of Mbed Studio's version of ARMC6.

bridadan · 2019-03-19T22:40:53Z

Ok @arekzaluski @thegecko @cmonr, I've removed the auto-setting of the license file. I still need to detect that it is the Mbed Studio version of ARMC6 so I can conditionally supply the --ide=mbed flag to each of the compiler, assembler, linker, and fromelf binaries.

cmonr · 2019-03-20T04:38:08Z

CI started whist discussions move forward.

cmonr · 2019-03-20T04:38:21Z

CC @ARMmbed/mbed-os-maintainers ^^^

cmonr · 2019-03-20T04:38:33Z

@bulislaw ^^^

mbed-ci · 2019-03-20T06:39:45Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 5
Build artifacts

0xc0170 · 2019-03-20T10:49:01Z

Ok @arekzaluski @thegecko @cmonr, I've removed the auto-setting of the license file. I still need to detect that it is the Mbed Studio version of ARMC6 so I can conditionally supply the --ide=mbed flag to each of the compiler, assembler, linker, and fromelf binaries.

Waiting for Mbed Studio team review

tools/toolchains/arm.py

thegecko

LGTM

0xc0170

Needs our final approval based on some recent concerns that are being taken care of = request changes.

0xc0170 · 2019-03-22T05:44:13Z

Started CI

mbed-ci · 2019-03-22T08:49:12Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 6
Build artifacts

We will merge this whether we hear from DSG or not by COB today

0xc0170 · 2019-03-23T15:28:30Z

We will merge this whether we hear from DSG or not by COB today

+1. This should be ready, merging now

bridadan requested a review from theotherjimmy March 14, 2019 23:21

ciarmcom requested review from a team March 15, 2019 00:00

ciarmcom added the needs: review label Mar 15, 2019

cmonr added the release-version: 5.12.0-rc3 label Mar 15, 2019

cmonr added needs: work and removed needs: review labels Mar 15, 2019

0xc0170 requested a review from arekzaluski March 15, 2019 09:52

bridadan marked this pull request as ready for review March 15, 2019 15:59

bridadan force-pushed the armc6_mbed_ide branch from 48a7eba to b89070d Compare March 15, 2019 19:25

0xc0170 added needs: CI and removed needs: work labels Mar 15, 2019

bridadan added 2 commits March 19, 2019 17:37

Clean up some whitespace

9824c3c

Version check the compiler in all build functions

6e629de

This enables the use of Mbed Studio's version of ARMC6.

bridadan force-pushed the armc6_mbed_ide branch from d1fcb36 to 6e629de Compare March 19, 2019 22:38

0xc0170 added needs: review and removed needs: CI labels Mar 20, 2019

thegecko reviewed Mar 20, 2019

View reviewed changes

tools/toolchains/arm.py Show resolved Hide resolved

thegecko approved these changes Mar 20, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Mar 20, 2019

theotherjimmy approved these changes Mar 20, 2019

View reviewed changes

0xc0170 added needs: review and removed ready for merge labels Mar 20, 2019

0xc0170 previously requested changes Mar 20, 2019

View reviewed changes

Add comments about the proper use of specific ARMC6 arguments

e382b50

0xc0170 added needs: CI and removed needs: review labels Mar 22, 2019

0xc0170 added ready for merge and removed needs: CI labels Mar 22, 2019

0xc0170 merged commit aca0f2f into ARMmbed:master Mar 23, 2019

0xc0170 removed the ready for merge label Mar 23, 2019

Allow the use of Mbed Studio's version of ARMC6 #10114

Allow the use of Mbed Studio's version of ARMC6 #10114

Uh oh!

Conversation

bridadan commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

theotherjimmy commented Mar 14, 2019

Uh oh!

ciarmcom commented Mar 15, 2019

Uh oh!

cmonr commented Mar 15, 2019

Uh oh!

cmonr commented Mar 15, 2019

Uh oh!

mbed-ci commented Mar 15, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 15, 2019

Uh oh!

bulislaw commented Mar 15, 2019

Uh oh!

bridadan commented Mar 15, 2019

Uh oh!

bridadan commented Mar 15, 2019

Uh oh!

0xc0170 commented Mar 15, 2019

Uh oh!

bridadan commented Mar 15, 2019

Uh oh!

bridadan commented Mar 15, 2019

Uh oh!

bridadan commented Mar 15, 2019

Uh oh!

0xc0170 commented Mar 15, 2019

Uh oh!

mbed-ci commented Mar 15, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Mar 16, 2019

Uh oh!

0xc0170 commented Mar 16, 2019

Uh oh!

0xc0170 commented Mar 16, 2019

Uh oh!

bridadan commented Mar 19, 2019

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

cmonr commented Mar 20, 2019

Uh oh!

mbed-ci commented Mar 20, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Mar 20, 2019

Uh oh!

Uh oh!

thegecko left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 22, 2019

Uh oh!

mbed-ci commented Mar 22, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Mar 23, 2019

Uh oh!

Uh oh!

bridadan commented Mar 14, 2019 •

edited

Loading

0xc0170 left a comment •

edited

Loading