Skip to content

Cellular: Fix network interface test for cellular targets #10120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Cellular: Fix network interface test for cellular targets #10120

merged 1 commit into from
Mar 20, 2019

Conversation

mirelachirica
Copy link
Contributor

@mirelachirica mirelachirica commented Mar 15, 2019 •
edited by cmonr
Loading

Description

Test's status_cb() can ignore cellular specific events because the values they are delivering are not connection statuses. Cellular connection statuses are still delivered with
NSAPI_EVENT_CONNECTION_STATUS_CHANGE events.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team March 15, 2019 12:00
@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@mirelachirica mirelachirica force-pushed the networkinterface_connection_status_fix branch from 9cc6ffd to ac757bf Compare March 15, 2019 12:14
@mirelachirica
Copy link
Contributor Author

Pushed astyle fix

SeppoTakalo
SeppoTakalo suggested changes Mar 15, 2019
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

Pull request type

Don't let the type empty, please fix

@mirelachirica mirelachirica force-pushed the networkinterface_connection_status_fix branch from ac757bf to d15bcfe Compare March 15, 2019 13:32
@cmonr cmonr requested a review from SeppoTakalo March 15, 2019 17:05
@0xc0170 0xc0170 removed the request for review from a team March 19, 2019 12:24
@NirSonnenschein
Copy link
Contributor

Starting CI

@mbed-ci
Copy link

mbed-ci commented Mar 20, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 0d86248 into ARMmbed:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mirelachirica @ciarmcom @0xc0170 @NirSonnenschein @mbed-ci @OPpuolitaival @SeppoTakalo @cmonr