Skip to content

Adding STM32_F439 as a new MTB target #10133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Adding STM32_F439 as a new MTB target #10133

merged 2 commits into from
Mar 20, 2019

Conversation

ashok-rao
Copy link
Contributor

@ashok-rao ashok-rao commented Mar 17, 2019

Description

Adding STM32_F439 MCU only (on a Module Carrier Board) as a new MTB target. This will be used as a base MCU for upcoming cellular MODEMs and other connectivity Module Expansion Boards (MEB).

Greentea logs attached below:
MTB_STM32_F439_GT_Logs_ARMCC_Pass.txt
MTB_STM32_F439_GT_Logs_GCC_Pass.txt
MTB_STM32_F439_GT_Logs_IAR_Pass.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 @jeromecoutant @cmonr

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170, cmonr, screamerbg and a team March 17, 2019 20:00
@ciarmcom
Copy link
Member

@ashok-rao, thank you for your changes.
@cmonr @0xc0170 @screamerbg @ARMmbed/mbed-os-maintainers please review.

@ashok-rao
Copy link
Contributor Author

Quick note: For GT tests, I've used IAR 8.32.1 & ARMC5.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARMC5 - had your own config to override it ? This target would support ARCM6 by default (inherits it).

@jeromecoutant
Copy link
Collaborator

Maybe description needs to be updated: "Adding STM32_L475" ?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 18, 2019

Maybe description needs to be updated: "Adding STM32_L475" ?

Files are being added to TARGET_STM32F439xI/TARGET_MTB_STM32_F439 and all its references. But the comment above is STM32_L475 - good catch. @ashok-rao Please confirm

@ashok-rao
Copy link
Contributor Author

@jeromecoutant @0xc0170 : Description error, now corrected. Thanks, good catch!

@ashok-rao
Copy link
Contributor Author

@jeromecoutant : General question on clock configuration, do you use STM32CubeMX to generate the clock configs or are these done manually for each of the targets?

@jeromecoutant
Copy link
Collaborator

do you use STM32CubeMX to generate the clock configs or are these done manually for each of the targets?

Yes, I am using CubeMX tool to check if there are no "red" values for all prescalers values.
I am also using CubeMx to build the peripheral pins files (see #9394)

MCO pins are not brought out on MTB / MCB design.
@ashok-rao
Copy link
Contributor Author

  • Review comments incorporated.
  • Adding GT logs for ARMC6

MTB_STM32_F439_GT_Logs_ARMC6_Pass.txt

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 19, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7d853b4 into ARMmbed:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants