Skip to content

Nanostack 802.15.4 RF drivers update #10142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Mar 18, 2019

Description

Sync Nanostack RF drivers from master copies:
-Atmel: v3.0.7
-MCR20A: v1.0.3
-S2LP: v0.0.4

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JarkkoPaso

Sync Nanostack RF drivers from master copies:
-Atmel: v3.0.7
-MCR20A: v1.0.3
-S2LP: v0.0.4
@ciarmcom ciarmcom requested review from JarkkoPaso and a team March 18, 2019 14:00
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@JarkkoPaso @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

This driver is used with 6LoWPAN and Wi-SUN stacks.

Driver is tested with X-Nucleo-S2868A1 RF expansion board. https://www.st.com/en/ecosystems/x-nucleo-s2868a1.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be turned into a link for readability - X-NUCLEO-S2868A1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we will keep that in mind when updating the readme next time.

Driver is tested with X-Nucleo-S2868A1 RF expansion board. https://www.st.com/en/ecosystems/x-nucleo-s2868a1.html

NOTE: Default SPI SCLK pin configuration is D13. On X-Nucleo-S2868A1, resistor R6 must be soldered instead of R11. For more information, see user manual UM2405. https://www.st.com/resource/en/user_manual/dm00498153.pdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be turned into a link for readability - UM2405 User manual

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we will keep that in mind when updating the readme next time.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

@artokin Making sure, this can come into 5.12.1 instead of 5.12.0-rc3, correct?

CC @ARMmbed/mbed-os-maintainers

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 19, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@artokin
Copy link
Contributor Author

artokin commented Mar 19, 2019

@cmonr , 5.12.1 is fine for this update.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

CI job restarted: jenkins-ci/mbed-os-ci_exporter

Failures don't immediately appear to be related to PR.

@NirSonnenschein
Copy link
Contributor

CI Has passed.
@JarkkoPaso would you still like to review this before merge?

@JarkkoPaso
Copy link

Looks good to me.

@0xc0170 0xc0170 merged commit 6da5f9b into ARMmbed:master Mar 20, 2019
@artokin artokin deleted the nanostack_rf_drivers_interrruptin_flag branch March 21, 2019 09:29
@@ -15,7 +15,7 @@
*/
#include "NanostackRfPhyMcr20a.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
This include should be 3 lines below... after the #if check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a note.

Fixed in #10185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants