-
Notifications
You must be signed in to change notification settings - Fork 3k
Nanostack 802.15.4 RF drivers update #10142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanostack 802.15.4 RF drivers update #10142
Conversation
Sync Nanostack RF drivers from master copies: -Atmel: v3.0.7 -MCR20A: v1.0.3 -S2LP: v0.0.4
@artokin, thank you for your changes. |
This driver is used with 6LoWPAN and Wi-SUN stacks. | ||
|
||
Driver is tested with X-Nucleo-S2868A1 RF expansion board. https://www.st.com/en/ecosystems/x-nucleo-s2868a1.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be turned into a link for readability - X-NUCLEO-S2868A1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we will keep that in mind when updating the readme next time.
Driver is tested with X-Nucleo-S2868A1 RF expansion board. https://www.st.com/en/ecosystems/x-nucleo-s2868a1.html | ||
|
||
NOTE: Default SPI SCLK pin configuration is D13. On X-Nucleo-S2868A1, resistor R6 must be soldered instead of R11. For more information, see user manual UM2405. https://www.st.com/resource/en/user_manual/dm00498153.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be turned into a link for readability - UM2405 User manual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we will keep that in mind when updating the readme next time.
@artokin Making sure, this can come into 5.12.1 instead of 5.12.0-rc3, correct? CC @ARMmbed/mbed-os-maintainers |
CI started |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
@cmonr , 5.12.1 is fine for this update. |
CI job restarted: Failures don't immediately appear to be related to PR. |
CI Has passed. |
Looks good to me. |
@@ -15,7 +15,7 @@ | |||
*/ | |||
#include "NanostackRfPhyMcr20a.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
This include should be 3 lines below... after the #if check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making a note.
Fixed in #10185
Description
Sync Nanostack RF drivers from master copies:
-Atmel: v3.0.7
-MCR20A: v1.0.3
-S2LP: v0.0.4
Pull request type
Reviewers
@JarkkoPaso