Skip to content

CellularBase -> CellularInterface tidy #10146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2019
Merged

CellularBase -> CellularInterface tidy #10146

merged 1 commit into from
Mar 29, 2019

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Mar 18, 2019 •
edited
Loading

Description

Remove remaining references to deprecated CellularBase in code, avoiding one warning.

Add deprecation to Doxygen.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team March 18, 2019 16:01
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

@kjbracey-arm Please take a look at the astyle results.

@SeppoTakalo
Copy link
Contributor

oh.. actually...

This breaks the Cypress binaries again...
Any change to vtable of NetworkInterface forces us to rebuild.

@cmonr cmonr requested a review from SeppoTakalo March 19, 2019 18:55
@kjbracey
Copy link
Contributor Author

Any change to vtable of NetworkInterface forces us to rebuild.

Hmph. Unfortunate. I'll omit that change then, and just do enough to fix the build warnings.. Shame I didn't spot the issue at review.

@kjbracey
CellularBase -> CellularInterface tidy
9ad9069 
Remove remaining references to deprecated CellularBase in code, avoiding
one warning.

Add deprecation to Doxygen.
@kjbracey kjbracey force-pushed the CellularInterface_tidy branch from 24266b5 to 9ad9069 Compare March 20, 2019 08:12
@kjbracey
Copy link
Contributor Author

I think this version nearly scrapes in to "docs update" - it only changes comments and replaces uses of CellularBase with CellularInterface, avoiding the deprecated typedef.

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

@SeppoTakalo Mind re-reviewing? Wiced rebuilding should not be needed anymore.

@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@kjbracey
Copy link
Contributor Author

Failure is something storage-related on a K66F ARMC6 run. Doesn't seem related.

@NirSonnenschein
Copy link
Contributor

restarted greentea

@cmonr cmonr merged commit f552f9d into ARMmbed:master Mar 29, 2019
@kjbracey kjbracey mentioned this pull request May 7, 2019
Merged
@kjbracey kjbracey deleted the CellularInterface_tidy branch May 7, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kjbracey @ciarmcom @cmonr @SeppoTakalo @mbed-ci @NirSonnenschein @adbridge