Skip to content

Update main.cpp #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update main.cpp #1015

wants to merge 1 commit into from

Conversation

PaggyCyntec
Copy link
Contributor

Propose to remove "union" because it causes the auto-test program not stable. (sometimes FAIL, sometimes PASS).

Propose to remove "union" because it causes the auto-test program not stable. (sometimes FAIL, sometimes PASS).
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2015

Hi, please sign http://developer.mbed.org/contributor_agreement/. I can't locate your nick on mbed, please share it once done.

You can remove that code, rather than commenting it out.

@PaggyCyntec
Copy link
Contributor Author

done, already signed the agreement, please help to review the changes, thank you.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2015

OK thanks, can you amend the commit by removing the commented code? The result will be :

int value_int;

@PaggyCyntec PaggyCyntec mentioned this pull request Apr 7, 2015
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2015

Closing this. For reference, look at git commit --amend or git rebase -i commands, might help you in the feature (they change the history, you should be aware of consequences :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants