Timer: remove hard-coded lp_ticker knowledge #10150
Merged
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kjbracey-arm, thank you for your changes. |
c1728p9
approved these changes
Mar 18, 2019
|
Please take a look at the astyle issues. |
The knowledge that lp_ticker runs in deep sleep was hard-coded with a comparison check of a ticker_data_t pointer against get_lp_ticker_data. Remove this hard-coded check, which adds a linker dependency against the low power ticker even if not being used - put a flag into the ticker_interface_t. A future extension might be to move this flag into the ticker_info_t provided by the HAL, but for the moment keep the assumption that lp_ticker does run, us_ticker doesn't.
kjbracey
force-pushed
the
timer_sleepcheck
branch
from
dd285bb to
534a3d2
Compare
cmonr
approved these changes
Mar 27, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 28, 2019
Timer: remove hard-coded lp_ticker knowledge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The knowledge that
lp_tickerruns in deep sleep was hard-coded with a comparison check of aticker_data_tpointer againstget_lp_ticker_data.Remove this hard-coded check, which adds a linker dependency against the low power ticker even if not being used - put a flag into the
ticker_interface_t.A future extension might be to move this flag into the
ticker_info_tprovided by the HAL, but for the moment keep the assumption thatlp_tickerdoes run,us_tickerdoesn't.Pull request type