Fix for LoRaWAN downlink sequence counter rollover #10154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasnainvirk
approved these changes
Mar 19, 2019
|
@itziardelatorre, thank you for your changes. |
cmonr
approved these changes
Mar 19, 2019
cmonr
added
needs: CI
release-version: 5.12.1
and removed
needs: CI
needs: review
labels
|
CI started |
|
Too early, aborted, will restart once other rc4 fixes complete. |
Test run: FAILEDSummary: 8 of 9 test jobs failed Failed test jobs:
|
|
@0xc0170 Failures seem to be unrelated to the PR. Is it possible to kick start the CI again ? |
|
restarting CI |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 26, 2019
Fix for LoRaWAN downlink sequence counter rollover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue related to downlink sequence counter rollover in LoRaWAN.
For the test, the downlink sequence counter of the downlink messages has been incremented by 1600 (< MAX_FCNT_GAP) several times. For example, until 64005 and following situation was shown:
Downlink sequence counter increased to 64005 (by 1600 steps)
The radio module accepts this, as expected.
After that, downlink sequence counter increased to 65536 (rollover for 32 bits sequence counter)
The radio module rejects this frame
With the change everything works fine.
Pull request type
Reviewers
Release Notes