Skip to content

Crypto access control additional tests #10160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

itayzafrir
Copy link
Contributor

Description

Additional tests for crypto access control

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom
Copy link
Member

@itayzafrir, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 19, 2019 20:02
@orenc17
Copy link
Contributor

orenc17 commented Mar 19, 2019

i think you should move the buffers outside of the functions, just to avoid stack issues

@itayzafrir
Copy link
Contributor Author

itayzafrir commented Mar 20, 2019

@orenc17

i think you should move the buffers outside of the functions, just to avoid stack issues

these are static const arrays, not on the stack

@itayzafrir
Copy link
Contributor Author

@avolinski please review

Copy link
Contributor

@moranpeker moranpeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@@ -473,22 +565,26 @@ utest::v1::status_t test_setup(const size_t number_of_cases)
}

Case cases[] = {
Case("open other partitions' key",
Case("open other partition's key",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@cmonr cmonr merged commit 1549c5c into ARMmbed:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants