BLE - Notify HCI driver of host stack inactivity #10162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This callback should be called by the host stack when it has no pending activities. It allows a driver to put its controller to sleep.
|
@pan-, thank you for your changes. |
paul-szczepanek-arm
approved these changes
Mar 20, 2019
cmonr
reviewed
Mar 20, 2019
| @@ -564,6 +564,9 @@ void BLE::callDispatcher() | |||
| timestamp_t nextTimestamp = (timestamp_t) (WsfTimerNextExpiration(&pTimerRunning) * WSF_MS_PER_TICK) * 1000; | |||
| if (pTimerRunning) { | |||
| nextTimeout.attach_us(timeoutCallback, nextTimestamp); | |||
| } else { | |||
| critical_section.disable(); | |||
There was a problem hiding this comment.
Why was this, or CriticalSectionLock critical_section; needed to begin with?
There was a problem hiding this comment.
In our case wsfOsReadyToSleep and WsfTimerNextExpiration needs to be called within a critical section.
cmonr
approved these changes
Mar 26, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 26, 2019
…ivity BLE - Notify HCI driver of host stack inactivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new function to the CordioHCIDriver interface:
on_host_stack_inactivity. That function is called by the host stack when it becomes inactive. It leave the opportunity to the driver to put the controller to sleep if all the conditions are met. Activity is resumed wheneverCordioHCIDriver::writeis called.This PR also fixes the type of the timeout local to
cardio::BLE::callDispatcher.Pull request type
Reviewers
@paul-szczepanek-arm @ARMmbed/team-cypress