Cellular: Increase receiving timeout for UDP echo non-blocking test #10184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirelachirica, thank you for your changes. |
SeppoTakalo
approved these changes
Mar 21, 2019
0xc0170
previously requested changes
Mar 22, 2019
mirelachirica
force-pushed
the
wise_1570_udp_echotest_nonblocking
branch
from
a05da1b to
6c44130
Compare
Is the commit message ok, now? |
|
@mirelachirica It would be good to know why the timeout needs to be increased, which is what I think @0xc0170 was asking for. |
…_ECHOTEST_NONBLOCK test Reason for needing greater timeout could be this test's performance. UDPSOCKET_ECHOTEST_BURST_NONBLOCK is implementing the receiving differently and is passing with 1 second timeout.
mirelachirica
force-pushed
the
wise_1570_udp_echotest_nonblocking
branch
from
6c44130 to
ec3c6f3
Compare
|
Commit message updated. |
|
CI started |
cmonr
approved these changes
Mar 26, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 26, 2019
…otest_nonblocking Cellular: Increase receiving timeout for UDP echo non-blocking test
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WISE-1570 is passing the UDPSOCKET_ECHOTEST_NONBLOCK only with a greater receiving timeout.
Note: UDPSOCKET_ECHOTEST_BURST_NONBLOCK on the other hand would pass even with a receiving timeout of 1 sec. I think the UDPSOCKET_ECHOTEST_NONBLOCK can be improved so that receiving timeout of 1 sec would be enough for this test too. I will create an issue about this to the test responsable team.
Pull request type