Skip to content

Fixed compilation error in LWIPStack class if lwip tcp is disabled. #10190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fixed compilation error in LWIPStack class if lwip tcp is disabled. #10190

merged 1 commit into from
Mar 27, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

Description

LWIP setsockopt member has now #if LWIP_TCP to prevent using of TCP PCB if TCP is disabled.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@tymoteuszblochmobica
Copy link
Contributor Author

@SeppoTakalo please review

@tymoteuszblochmobica
Copy link
Contributor Author

@mikaleppanen please review

@tymoteuszblochmobica
Copy link
Contributor Author

@kjbracey-arm please review

@ciarmcom ciarmcom requested review from a team March 21, 2019 18:00
@ciarmcom
Copy link
Member

@tymoteuszblochmobica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 22, 2019

@tymoteuszblochmobica Use Reviewers section in the PR to request reviews (will be added automatically to PR reviewers list)

@NirSonnenschein
Copy link
Contributor

starting CI

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@alekla01
Copy link
Contributor

restarted jenkins-ci/exporter

@SeppoTakalo SeppoTakalo mentioned this pull request Mar 26, 2019
Closed
cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
Merge pull request ARMmbed#10190 from tymoteuszblochmobica/fixtcp
97059e8 
Fixed compilation error in LWIPStack class if lwip tcp is disabled.
@cmonr cmonr merged commit e8e6ad4 into ARMmbed:master Mar 27, 2019
@tymoteuszblochmobica tymoteuszblochmobica deleted the fixtcp branch April 25, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tymoteuszblochmobica @ciarmcom @0xc0170 @NirSonnenschein @mbed-ci @alekla01 @SeppoTakalo @cmonr