Skip to content

Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h #10212

merged 1 commit into from
Mar 28, 2019

Conversation

ecoromka
Copy link
Contributor

@ecoromka ecoromka commented Mar 25, 2019 •
edited
Loading

Description

Fix of TEMPSENSOR_CAL1_TEMP constant for F3 series targets.

Datasheet says it is 30. This leads to an error in internal temperature readings, using provided macro.

Datasheet, page 150/173, Table 90: https://www.st.com/resource/en/datasheet/stm32f303re.pdf
Same for all MCU, mentioned in correspondig file (STM32F301x8 || STM32F302x8 || STM32F302xC || STM32F302xE || STM32F303x8 || STM32F303xC || STM32F303xE || STM32F318xx || STM32F328xx || STM32F334x8 || STM32F358xx || STM32F398xx).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

Release Notes

@ecoromka ecoromka closed this Mar 25, 2019
@ecoromka ecoromka reopened this Mar 25, 2019
@ecoromka ecoromka closed this Mar 25, 2019
@ecoromka ecoromka reopened this Mar 25, 2019
@ecoromka
Copy link
Contributor Author

It's the first time i'm making a pull request. I've tried to follow the rules, please indicate if anything wrong.

@ciarmcom ciarmcom requested review from screamerbg and a team March 25, 2019 12:00
@ciarmcom
Copy link
Member

@ecoromka, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@ecoromka
Copy link
Contributor Author

Oh, it corresponds to an issue: #10203

@ecoromka
Copy link
Contributor Author

Should I edit the code to match travis astyle suggestions in order to pass the check? I'm confused 'cause I only changed "25" to "30".

If I make those stlye changes, how do I restart the check? New commit and new pull request?

Thank you!

@jeromecoutant
Copy link
Collaborator

@ARMmbed/mbed-os-maintainers There should not be any astyle check in this directory

@cmonr
Copy link
Contributor

cmonr commented Mar 25, 2019

@jeromecoutant Correct, that's my bad.

Waiting on #10221 for astyle fix.

@cmonr
Copy link
Contributor

cmonr commented Mar 25, 2019

@ecoromka No change needed on your side for now. Will let you know if that changes.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019 •
edited
Loading

Info: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

@ecoromka In the future, you can also open a pull request directly from a branch as well.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

Hmm... The astyle fix is missing this fix: #10222

@NirSonnenschein
Copy link
Contributor

please re-base when you have time, it should resolve the astyle issue

@ecoromka
Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h
757b9e2 
Fix TEMPSENSOR_CAL1_TEMP according to datasheet.
@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

Info: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

CI started

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
Merge pull request ARMmbed#10212 from ecoromka/master
61524b8 
 Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h
@mbed-ci
Copy link

mbed-ci commented Mar 26, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

No idea why GCC_ARM failed for a completely unrelated target.

Restarted job, but may need to restart entire pipeline.

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

Pipeline it is.

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@NirSonnenschein
Copy link
Contributor

@screamerbg would you still like to review this before it is merged (tiny PR)?

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019
Merge pull request ARMmbed#10212 from ecoromka/master
81bb726 
 Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h
@cmonr cmonr merged commit 6443e43 into ARMmbed:master Mar 28, 2019
@jeromecoutant jeromecoutant mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@screamerbg screamerbg Awaiting requested review from screamerbg

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ecoromka @ciarmcom @jeromecoutant @cmonr @NirSonnenschein @mbed-ci