Skip to content

PSA - TFM manfiest scan #10218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2019
Merged

PSA - TFM manfiest scan #10218

merged 3 commits into from
Mar 29, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 25, 2019

Description

Change the way TFM code generator finds the PSA manifests

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa

Release Notes

alzix
alzix approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@alzix alzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/TARGET_PSA/TARGET_TFM/COMPONENT_SPE/autogen/tfm_partition_defs.inc Outdated
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did rerun of generation tool introduced so many changes?
Do we have line ending problems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... fixed that

@ciarmcom ciarmcom requested review from a team March 25, 2019 16:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

Once #10222 is in, this PR will need a rebase.
Fixes the currelt failing astyle issue...

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

🤣

The travis-ci/psa-autogen job is complainging about a lack of a newline in the files.

@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 594a1d1 into ARMmbed:master Mar 29, 2019
@cmonr cmonr removed the needs: CI label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@alzix alzix alzix approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@orenc17 @ciarmcom @cmonr @mbed-ci @theotherjimmy @alzix @0xc0170 @adbridge