-
Notifications
You must be signed in to change notification settings - Fork 3k
Update flash algo default with CPM 0.2.4 #10234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
### Description Cmsis Pack Manager 0.2.4 corrected parsing of specifically the flash algorithm default attribute. It was allowed to be "0", "1", "true" and "false". CPM 0.2.3 parsed "1" into false, and this behavior was corrected in 0.2.4. This PR uses 0.2.4 to update the index. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change
@theotherjimmy, thank you for your changes. |
😆 |
Since GitHub refused to render the diff, I've copied all the interesting parts of the diff and attached it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
CI started |
…0.2.4 Update flash algo default with CPM 0.2.4
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
Please take a look at the build failures. That appear to be valid. |
@cmonr that should fix it. |
@bridadan could you please re-review ? |
CI started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theotherjimmy I can't thank you enough for making your second change a second commit. If I had to review the giant one again I would not be too thrilled 🎉
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
CI job restarted:
|
…0.2.4 Update flash algo default with CPM 0.2.4
Description
Cmsis Pack Manager 0.2.4 corrected parsing of specifically the flash
algorithm default attribute. It was allowed to be "0", "1", "true"
and "false". CPM 0.2.3 parsed "1" into false, and this behavior was
corrected in 0.2.4.
This PR uses 0.2.4 to update the index.
Pull request type