Skip to content

Update flash algo default with CPM 0.2.4 #10234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

theotherjimmy
Copy link
Contributor

Description

Cmsis Pack Manager 0.2.4 corrected parsing of specifically the flash
algorithm default attribute. It was allowed to be "0", "1", "true"
and "false". CPM 0.2.3 parsed "1" into false, and this behavior was
corrected in 0.2.4.

This PR uses 0.2.4 to update the index.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

### Description

Cmsis Pack Manager 0.2.4 corrected parsing of specifically the flash
algorithm default attribute. It was allowed to be "0", "1", "true"
and "false". CPM 0.2.3 parsed "1" into false, and this behavior was
corrected in 0.2.4.

This PR uses 0.2.4 to update the index.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change
@ciarmcom ciarmcom requested review from a team March 26, 2019 16:00
@ciarmcom
Copy link
Member

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

3,330 additions, 3,330 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

😆

@bridadan
Copy link
Contributor

Since GitHub refused to render the diff, I've copied all the interesting parts of the diff and attached it.
interesting_diff.txt

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

CI started

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
…0.2.4

Update flash algo default with CPM 0.2.4
@mbed-ci
Copy link

mbed-ci commented Mar 26, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

Please take a look at the build failures. That appear to be valid.

@theotherjimmy
Copy link
Contributor Author

@cmonr that should fix it.

@adbridge
Copy link
Contributor

@bridadan could you please re-review ?

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

CI started

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theotherjimmy I can't thank you enough for making your second change a second commit. If I had to review the giant one again I would not be too thrilled 🎉

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

CI job restarted: jenkins-ci/exporter

armclang: error: Failed to check out a license.

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019
…0.2.4

Update flash algo default with CPM 0.2.4
@cmonr cmonr merged commit 6fccfeb into ARMmbed:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants