Skip to content

Add Python modules to LICENSE file #10240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add Python modules to LICENSE file #10240

merged 1 commit into from
Apr 1, 2019

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Mar 27, 2019 •
edited
Loading

Description

Specify a license for every module from requirements.txt.

Fixes #10123

As you can see this list is not complete yet. I could use some help with a few modules marked as TODO. These cases need clarification.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170 and a team March 27, 2019 12:00
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲

@cmonr cmonr added needs: CI and removed needs: CI labels Mar 27, 2019
cmonr
cmonr reviewed Mar 27, 2019
View reviewed changes
Docs: Add Python modules to LICENSE file
5089253 
Specify a license for every module from requirements.txt.
@fkjagodzinski fkjagodzinski force-pushed the docs_update-license_py_modules branch from 53a524b to 5089253 Compare March 28, 2019 09:39
@fkjagodzinski
Copy link
Member Author

Thanks @cmonr 👍, I've applied your changes and squashed the commits.
The PR is ready for review.

@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2019

CI started

@cmonr cmonr requested a review from a team March 28, 2019 22:58
@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2019

@ARMmbed/mbed-os-maintainers Would be nice for someone else to ack this before merge.

@0xc0170 0xc0170 merged commit fe9beae into ARMmbed:master Apr 1, 2019
@fkjagodzinski fkjagodzinski deleted the docs_update-license_py_modules branch April 9, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fkjagodzinski @ciarmcom @cmonr @0xc0170 @NirSonnenschein