cellular: valgrind defect fix #10269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarvte
approved these changes
Mar 29, 2019
|
@TeemuKultala, thank you for your changes. |
cmonr
approved these changes
Mar 29, 2019
|
@jarvte could you please re-approve (your approval seems to have been cleared, although I don't see any subsequent changes) |
jarvte
approved these changes
Mar 31, 2019
0xc0170
requested changes
Apr 1, 2019
|
How did you run valgrind? |
at_cellulardevicetest.cpp: fix potential memory leak at_cellularsmstest.cpp: fix potential memory leak, uninitialized memory conditional athandlertest.cpp: fix potential memory leak, uninitialized memory conditional, uninitialized memory read ATHandler_stub.cpp, ATHandler_stub.h: fix potential memory leak, uninitialized memory conditional
|
Discovered valgrind defect types for each file added to the commit message. How the defects are fixed can be seen by inspecting the changes. Valgrind test was ran this way: After this the report is available in Testing/current_date_time folder |
0xc0170
approved these changes
Apr 3, 2019
Test run: SUCCESSSummary: 1 of 1 test jobs passed |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes cellular Valgrind memtest defects. Tested with unit tests. cellulardevicetest.cpp valgrind problem is going to be addressed separately
Pull request type
Reviewers
@jarvte @mirelachirica