Skip to content

Parse Errors and Warnings from Arm Compiler 6 #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Parse Errors and Warnings from Arm Compiler 6 #10276

merged 1 commit into from
Apr 1, 2019

Conversation

theotherjimmy
Copy link
Contributor

Description

Turns out we were not doing this. I think it's really important that
we display warnings when they exists.

Further, this makes the parse_output function run on the linker. It was
not run on the linker before.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy theotherjimmy requested a review from bridadan March 29, 2019 16:16
@ciarmcom ciarmcom requested review from a team March 29, 2019 18:00
@ciarmcom
Copy link
Member

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

bridadan
bridadan approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other compilers now pick up linker errors as well? Like GCC and IAR? Or is that only implemented in ARMC6 for now?

@theotherjimmy
Copy link
Contributor Author

@bridadan They'll try, but I don't know how successful they'll be.

@theotherjimmy
Copy link
Contributor Author

I'll analyze that and make a follow on PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 136e0e3 into ARMmbed:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theotherjimmy @ciarmcom @0xc0170 @mbed-ci @cmonr @bridadan