Remove CFSTORE VERSION file (colliding with an ARM 6.12 C++ header file) #10280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidsaada, thank you for your changes. |
0xc0170
approved these changes
Apr 1, 2019
|
CI started while waiting for reviewers |
dannybenor
approved these changes
Apr 1, 2019
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
|
@SenRamakri As this is trival fix removing file not used, its ready for merge but still if you find time today to review, please do |
Specifically, please check that it resolves the build problem with ARM 6.12, as I don't have this compiler installed. |
SenRamakri
approved these changes
Apr 1, 2019
0xc0170
added
needs: review
ready for merge
and removed
ready for merge
needs: review
labels
|
@0xc0170 - I have already verified. This is good to get in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the "VERSION" file from the CFSTORE library, as it collides with a C++ header file having the same name, when compiling mbed-os with ARM 6.12 compiler.
Note that this is a temporary fix to resolve this compiler issue. #10258 should remove CFSTORE feature altogether in the next major release.
Pull request type
Reviewers
@SenRamakri