Adding support for S2_LP (WiSUN) as a new MTB target #10281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 7, 2018 16:44
Based on v1.1.0 of S2_LP MCB using STM32F429ZIT6.
Based on v1.1.0 of S2_LP MCB using STM32F429ZIT6.
|
@0xc0170 / @cmonr : Can this get in for 5.12.1 as WiSUN is now released with 5.12.0 ? cc @TuomoHautamaki ..FYI. |
ciarmcom
requested review from
0xc0170,
cmonr,
JarkkoPaso,
mikter,
screamerbg and
a team
|
@ashok-rao, thank you for your changes. |
jeromecoutant
approved these changes
Apr 1, 2019
SeppoTakalo
suggested changes
Apr 1, 2019
JarkkoPaso
approved these changes
Apr 1, 2019
0xc0170
reviewed
Apr 1, 2019
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F429xI/TARGET_MTB_STM_S2LP/system_clock.c
Outdated
Show resolved
Hide resolved
0xc0170
requested changes
Apr 1, 2019
0xc0170
changed the title
added 2 commits
April 1, 2019 11:16
Removing USBDEVICE since USB pins are NOT brought out on the MTB/MCB.
|
@0xc0170 , Thanks! Now done. |
|
Tested with 5cb1c64 and still works perfectly well. |
0xc0170
reviewed
Apr 1, 2019
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F429xI/TARGET_MTB_STM_S2LP/system_clock.c
Outdated
Show resolved
Hide resolved
0xc0170
approved these changes
Apr 1, 2019
|
Ci started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
|
@ashok-rao I dont understand what did cause this and no one noticed but there seems to be duplication of the commits (checking them, they do not look identical - causing some conflicts locally, will do manual patching) |
|
This was not easy to resolve - please review #10326 - commits from this PR that are resolved properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding STM32_F429 MCU + S2_LP (on a Module Carrier Board) as a new MTB target. This PR adds HW support for WiSUN supported targets in Mbed OS.
Greentea logs attached below:
MTB_STM_S2LP_GT_Logs_ARMC6_Pass.txt
MTB_STM_S2LP_GT_Logs_GCC_Pass.txt
MTB_STM_S2LP_GT_Logs_IAR_Pass.txt
Pull request type
Reviewers
@0xc0170 @cmonr @jeromecoutant @mikter @JarkkoPaso
Release Notes