Skip to content

Revert limiting Renesas targets to ARMC6 #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Apr 1, 2019

Description

These targets appear to run fine with ARMC5.

This reverts commit 2b75dfd.

It also fixes #10253.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri

Release Notes

These targets appear to run fine with ARMC5.

This reverts commit 2b75dfd.
@bridadan bridadan changed the title Revert "Only enable ARMC6 for a few targets" Revert limiting Renesas targets to ARMC6 Apr 1, 2019
@ciarmcom ciarmcom requested review from SenRamakri and a team April 1, 2019 23:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 1, 2019

@bridadan, thank you for your changes.
@SenRamakri @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2019

I'm fine with the change, but do we remember why it was limited to ARMC6 in the first place?

CC @SenRamakri @bridadan @deepikabhavnani @ARMmbed/team-renesas

@0xc0170 0xc0170 requested a review from a team April 2, 2019 07:45
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2019

@ARMmbed/team-renesas Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2019

Making a note that we're waiting for a response to #10288 (comment) before bringing in.

@0xc0170 0xc0170 merged commit 25371d4 into ARMmbed:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RZ_A1XX (RZ_A1H & GR_LYCHEE) incorrectly marked as ARM Compiler 6 only
7 participants