Cellular: Basic driver for Quectel EC25/EC21 #10292

hasnainvirk · 2019-04-02T12:43:19Z

Description

Provides basic power up / power down sequences for Quectel EC2X series
modems. Can be used in PPP mode. For using the on-board IP stack, we
will need to add and implement classes that provide context.

Driver constructor takes power and reset control pins along with the
FileHandle. A default construction is provided which can be chosen by
the application in its mbed_app.json. Otherwise the user is free to
construct as per demand.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

ciarmcom · 2019-04-02T13:00:35Z

@hasnainvirk, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

hasnainvirk · 2019-04-02T13:05:57Z

@AnttiKauppila @AriParkkila @kjbracey-arm @ARMmbed/mbed-os-wan Please review.

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.h

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp

hasnainvirk · 2019-04-04T07:44:52Z

@kivaisan @AriParkkila Please review again.

0xc0170 · 2019-04-08T09:36:17Z

[X] New target driver

Please do not add new/remove the current PR type. This one falls into target update. I've fixed it

0xc0170 · 2019-04-08T09:39:00Z

Ci started

mbed-ci · 2019-04-08T10:36:48Z

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6
jenkins-ci/mbed-os-ci_build-ARMC5

Provides basic power up / power down sequences for Quectel EC2X series modems. Can be used in PPP mode. For using the on-board IP stack, we will need to add and implement classes that provide context. Driver constructor takes power and reset control pins along with the FileHandle. A default construction is provided which can be chosen by the application in its mbed_app.json. Otherwise the user is free to construct as per demand.

A test trace was left lurking around. Removed in this commit.

AT+CREG command can also provide information regarding lac/ci/lat etc so we should set the mode correctly in cellular properties structure.

Standard 3GPP TS27.007 states that the AT+CGSN command can optionally have type parameter that determines the output. However Quiectel EC2X series doesn't accept parameters. We need to reflect that in the cellular properties setup.

A little tidying up was needed as there was some boiler plate code that could be shoved into a corner and reused.

To make this driver more useful, we needed to do some changes. The wirings for the modem can differ on the board so we also need to be flexible in our approach. It is now mandatory to provide the power pin and pin polarity in the constructor alongwith the file handle. Reset pin is optional.

hasnainvirk · 2019-04-08T14:35:10Z

@AnttiKauppila @AriParkkila @kivaisan Please review again.

AriParkkila

Is it intentionally assumed that pwr and rst pin polarity are the same?

hasnainvirk · 2019-04-09T07:15:01Z

Is it intentionally assumed that pwr and rst pin polarity are the same?

Yes that is right.

For default construction of the driver, it would be necessary to define the pins. However as we don't know the correct pins, until/unless user sets them up for us. So it makes sense to mark the pins as NC. It would be easier to debug if the pins are set to NC if user forgot to set them up.

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.h

0xc0170 · 2019-04-09T10:16:24Z

CI started

mbed-ci · 2019-04-09T13:08:39Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-04-09T13:20:20Z

Failed test jobs:

Test passed (second round).

hasnainvirk force-pushed the ec2x_driver branch 2 times, most recently from 3db6e4f to 1c874da Compare April 2, 2019 12:47

hasnainvirk changed the title ~~Basic driver for Quectel EC25/EC21~~ [Cellular] Basic driver for Quectel EC25/EC21 Apr 2, 2019

ciarmcom requested review from a team April 2, 2019 13:00

ciarmcom added the needs: review label Apr 2, 2019

hasnainvirk force-pushed the ec2x_driver branch from 1c874da to 49bebb4 Compare April 3, 2019 06:07

AriParkkila suggested changes Apr 3, 2019

View reviewed changes

hasnainvirk force-pushed the ec2x_driver branch from cfee83c to cae857a Compare April 3, 2019 08:21

kivaisan reviewed Apr 4, 2019

View reviewed changes

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.h Outdated Show resolved Hide resolved

kivaisan reviewed Apr 4, 2019

View reviewed changes

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp Outdated Show resolved Hide resolved

kivaisan reviewed Apr 4, 2019

View reviewed changes

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp Show resolved Hide resolved

AriParkkila approved these changes Apr 4, 2019

View reviewed changes

0xc0170 changed the title ~~[Cellular] Basic driver for Quectel EC25/EC21~~ Cellular: Basic driver for Quectel EC25/EC21 Apr 4, 2019

0xc0170 approved these changes Apr 8, 2019

View reviewed changes

0xc0170 added needs: CI release-version: 5.12.2 and removed needs: review labels Apr 8, 2019

0xc0170 added needs: work and removed needs: CI labels Apr 8, 2019

Hasnain Virk added 4 commits April 8, 2019 17:32

Removing left over tracing

ab978bd

A test trace was left lurking around. Removed in this commit.

CREG can handle lac/ci/lat

df7f8cd

AT+CREG command can also provide information regarding lac/ci/lat etc so we should set the mode correctly in cellular properties structure.

AT+CGSN with EC2X does not take parameter

24178bc

Standard 3GPP TS27.007 states that the AT+CGSN command can optionally have type parameter that determines the output. However Quiectel EC2X series doesn't accept parameters. We need to reflect that in the cellular properties setup.

Hasnain Virk added 2 commits April 8, 2019 17:32

Tidying up the boiler plate code

57d9e27

A little tidying up was needed as there was some boiler plate code that could be shoved into a corner and reused.

hasnainvirk force-pushed the ec2x_driver branch from 48fd512 to 7ebfa90 Compare April 8, 2019 14:33

0xc0170 added needs: review and removed needs: work labels Apr 8, 2019

AriParkkila approved these changes Apr 9, 2019

View reviewed changes

AnttiKauppila approved these changes Apr 9, 2019

View reviewed changes

kivaisan approved these changes Apr 9, 2019

View reviewed changes

features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.h Outdated Show resolved Hide resolved

0xc0170 added needs: CI and removed needs: review labels Apr 9, 2019

0xc0170 added ready for merge and removed needs: CI labels Apr 9, 2019

cmonr merged commit 6dbc00d into ARMmbed:master Apr 9, 2019

cmonr removed the ready for merge label Apr 9, 2019

Cellular: Basic driver for Quectel EC25/EC21 #10292

Cellular: Basic driver for Quectel EC25/EC21 #10292

Uh oh!

Conversation

hasnainvirk commented Apr 2, 2019 • edited by 0xc0170 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Apr 2, 2019

Uh oh!

hasnainvirk commented Apr 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hasnainvirk commented Apr 4, 2019

Uh oh!

0xc0170 commented Apr 8, 2019

Uh oh!

0xc0170 commented Apr 8, 2019

Uh oh!

mbed-ci commented Apr 8, 2019

Test run: FAILED

Uh oh!

hasnainvirk commented Apr 8, 2019

Uh oh!

AriParkkila left a comment

Choose a reason for hiding this comment

Uh oh!

hasnainvirk commented Apr 9, 2019

Uh oh!

Uh oh!

0xc0170 commented Apr 9, 2019

Uh oh!

mbed-ci commented Apr 9, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hasnainvirk commented Apr 2, 2019 •

edited by 0xc0170

Loading

0xc0170 commented Apr 9, 2019 •

edited

Loading