Skip to content

Build script: add explicit console log in case of linker script error #10296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Apr 2, 2019

Description

For some reason, I made a mistake in my development branch, and forgot to have a linker script for my target.
I spent some time to find the issue as there was no console log at all...

This print addition is for the next time :-)

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@ciarmcom ciarmcom requested review from theotherjimmy and a team April 2, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 2, 2019

@jeromecoutant, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d1da622 into ARMmbed:master Apr 3, 2019
@jeromecoutant jeromecoutant deleted the PR_NOLINKER branch April 3, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants