BLE: force mandatory services to have lowest handles #10302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
As much as I disliked the behaviour exposed by the services (instantiation before initialisation of the GattServer...) there's not much we can do about it now. Thanks for the workaround @paul-szczepanek-arm
|
@paul-szczepanek-arm, thank you for your changes. |
0xc0170
approved these changes
Apr 3, 2019
pan-
approved these changes
Apr 3, 2019
It should not rewrite it, will be fixed |
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory services can be added before or after user added services. The nordic monitor application assumes they are the first service discovered and fail if they are not. This fix makes sure the mandatory service is added before any user service.
Pull request type
Reviewers
@pan-