Skip to content

Cellular: new state machine state and better info from stm #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2019
Merged

Cellular: new state machine state and better info from stm #10324

merged 2 commits into from
Apr 9, 2019

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Apr 5, 2019

Description

Added new state (signal quality) and more information about progress so application/driver can build recovery logic.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

@ciarmcom ciarmcom requested review from AriParkkila and a team April 5, 2019 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 5, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

AriParkkila
AriParkkila approved these changes Apr 5, 2019
View reviewed changes
features/cellular/framework/AT/AT_CellularContext.cpp Outdated
@@ -902,7 +902,9 @@ void AT_CellularContext::cellular_callback(nsapi_event_t ev, intptr_t ptr)
if (ev >= NSAPI_EVENT_CELLULAR_STATUS_BASE && ev <= NSAPI_EVENT_CELLULAR_STATUS_END) {
cell_callback_data_t *data = (cell_callback_data_t *)ptr;
cellular_connection_status_t st = (cellular_connection_status_t)ev;
_cb_data.error = data->error;
if (ev != CellularStateRetryEvent) { // retry event may report errors but it's a retry so don't care about the error
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

0xc0170
0xc0170 requested changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One commit having multiple logical things changed

features/cellular/framework/device/CellularStateMachine.h Outdated
int _status;
PlatformMutex _mutex;
cell_signal_quality _signal_quality;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cell_signal_quality vs cellular_connection_status_t - not having the same name scheme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

features/cellular/framework/device/CellularStateMachine.h Outdated
@@ -161,7 +165,7 @@ class CellularStateMachine {

Callback<void(nsapi_event_t, intptr_t)> _event_status_cb;

CellularNetwork *_network;
CellularNetwork &_network;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this related to adding new connection status ? separate commit with explanation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, will do this fix in a different pr.

@jarvte jarvte force-pushed the more_info_from_stm branch from 32a1015 to bd423ca Compare April 8, 2019 05:50
@jarvte
Copy link
Contributor Author

jarvte commented Apr 8, 2019

Forced pushed review fixes.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2019 •
edited
Loading

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2019

Please rebase, will restart CI

@jarvte jarvte closed this Apr 9, 2019
@jarvte jarvte deleted the more_info_from_stm branch April 9, 2019 10:34
@sg- sg- removed the needs: work label Apr 9, 2019
@jarvte jarvte restored the more_info_from_stm branch April 9, 2019 10:35
@jarvte jarvte reopened this Apr 9, 2019
Cellular: new state machine state and better info from stm
2470a36 
Added new state (signal quality) and more information about progress
so application/driver can build recovery logic.
@jarvte jarvte force-pushed the more_info_from_stm branch from bd423ca to bb7fa99 Compare April 9, 2019 10:57
Cellular: fix state machine to compile after master rebase
8234f00 
Fix automatic rebase error with cellulardevice.cpp
@jarvte jarvte force-pushed the more_info_from_stm branch from bb7fa99 to 8234f00 Compare April 9, 2019 11:02
@jarvte
Copy link
Contributor Author

jarvte commented Apr 9, 2019

@0xc0170 rebase done. Also force-pushed fixes that were wrong after rebase.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 2cb157c into ARMmbed:master Apr 9, 2019
@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

Moved to 5.13.0-rc1.

Patch does not want to be applied successfully to the mbedf-os-5.12 branch, even by itself.

@jarvte jarvte deleted the more_info_from_stm branch April 10, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jarvte @ciarmcom @0xc0170 @mbed-ci @cmonr @AriParkkila @sg-