Add INTERRUPTIN compilation guard for ESP8266 #10329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already on master, so this one is needed for 5.12 branch, now release-candidate? I can cherry-pick it |
|
Cherrypicked - part of 5.12.1 rc |
|
@michalpasztamobica, thank you for your changes. |
SeppoTakalo
approved these changes
Apr 8, 2019
|
I can close this, integreated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the same fix as #10244 , but without the astyle fixes. Original description:
In case INTERRUPTIN flag is not set for a particular target, ESP8266 source code should not be compiled. The reason is that it relies on submodules (such as UARTSerial), which will not compile without INTERRUPTIN flag set. Thus, the compilation fails with an error without the flag.
The solution to the issue is to guard the ESP8266 with a macro checking that INTERRUPTIN flag is set.
This fixes #10061 .
Pull request type
Reviewers
@SeppoTakalo
@VeijoPesonen