FUTURE_SEQUANA: Add suport for ARMC6 #10346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves all PDL drivers into common source and include directories to alleviate issue with Windows version of GNU Make 4.x maximum command line length limit.
Also enabled ARMC6 compiler for FUTURE_SEQUANA family of targets.
orenc17
suggested changes
Apr 8, 2019
| @@ -615,11 +615,13 @@ __STATIC_INLINE void Cy_IPC_Drv_SetInterrupt(IPC_INTR_STRUCT_Type* base, uint32 | |||
| *******************************************************************************/ | |||
| __STATIC_INLINE void Cy_IPC_Drv_ClearInterrupt(IPC_INTR_STRUCT_Type* base, uint32_t ipcReleaseMask, uint32_t ipcNotifyMask) | |||
| { | |||
| uint32_t unused; | |||
There was a problem hiding this comment.
i think you should add volatile so the compiler wont optimize that out
There was a problem hiding this comment.
I was thinking about it, but the ARM clang reference manual states (section 7.12 Qualifiers):
Value computation of an lvalue expression with a volatile qualified type constitutes an access to the corresponding object, even when the value is discarded.
So I think it's ok, as it's hw register (data field), that is declared volatile. Variable unused could be skipped.
Same holds true for GCC.
|
@lrusinowicz, thank you for your changes. |
orenc17
approved these changes
Apr 8, 2019
0xc0170
approved these changes
Apr 9, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds necessary set of changes to support ARMC6 compiler for FUTURE_SEQUANA family of targets. I've run default set of mbed tests on it and tests generally pass, except for a few failures related to device_key and flash API. I strongly suspect these are unrelated and would rather fix them separately.
Intended to fix #9578.
Pull request type
Reviewers
Release Notes