Skip to content

Parse M33 + GCC_ARM map files #10348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Conversation

theotherjimmy
Copy link
Contributor

Description

Turns out that under certain circumstances, GCC_ARM will emit
whitespace-delimited text in map files. Before this PR, Memap's
GCC_ARM map file parsing logic assumes that sections assumes
that the sections always start the string. This PR allows the
sections to be prefixed by whitespace.

Fixes #10109

Note for reviewers: the first commit cleans up lint warnings and
the second commit fixes the bug.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team April 8, 2019 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 8, 2019

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 8, 2019 19:00
@bridadan
Copy link
Contributor

bridadan commented Apr 8, 2019

Changes look fine, but you get to make travis happy now :)

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 8e02592 into ARMmbed:master Apr 10, 2019
@cmonr cmonr removed the needs: CI label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map file extraction is failing with GCC and M33
6 participants