Skip to content

Update to LWIP 2.1.2 #10353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Update to LWIP 2.1.2 #10353

merged 2 commits into from
Apr 15, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

@tymoteuszblochmobica tymoteuszblochmobica commented Apr 9, 2019

Description

Latest LWIP 2.1.2 with necessary patches integrated with MbebOS

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@mikaleppanen
@kjbracey-arm

Release Notes

Latest LWIP 2.1.2 released is now integrated with MbedOS.
New LWIP release has improvements in following areas:

-IP4 routing
-IP6 scopes and zones
-dhcp6
-nd6
-tcp
-Sockets
-Binding network interfaces to sockets

LWIP changelog contains detailed changes

MbedOS dedicated patches were applied to new LWIP.
Multihoming was refactored due to new socket-interface bind implementation.

@ciarmcom ciarmcom requested review from kjbracey, mikaleppanen, SeppoTakalo and a team April 9, 2019 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 9, 2019

@tymoteuszblochmobica, thank you for your changes.
@SeppoTakalo @kjbracey-arm @mikaleppanen @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second commit is only about "Multihoming was refactored due to new socket-interface bind implementation." ?
The commit changes lot of files (adding parameters, new functions) so not certain what is this refactor doing - would it make sense to add there more details or split ?

@michalpasztamobica
Copy link
Contributor

@0xc0170 , I think the most important reviews are still to come from @mikaleppanen , @kjbracey-arm and @SeppoTakalo . Please do not merge until at least one of them approves...

Regarding the commit split, the idea was the following:

  1. Commit the actual new LWIP.
  2. Get multihoming working again.

The second commit message body is "Multihoming fixed according to new LWIP implementation." Perhaps this should become the title of the commit message instead of just being its body?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2019

@0xc0170 , I think the most important reviews are still to come from @mikaleppanen , @kjbracey-arm and @SeppoTakalo . Please do not merge until at least one of them approves...

👍

The second commit message body is "Multihoming fixed according to new LWIP implementation." Perhaps this should become the title of the commit message instead of just being its body?

Could be. Let other reviewers look at this as well

@SeppoTakalo
Copy link
Contributor

Looks OK.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Apr 12, 2019

Info: This PR has now been rebased.

Travis CI did not want to start, so I gave the PR an updated sha to generate the webhook.

@cmonr
Copy link
Contributor

cmonr commented Apr 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2019

Exporters restarted - internal symlink error

@0xc0170 0xc0170 merged commit b0ba3d3 into ARMmbed:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants