-
Notifications
You must be signed in to change notification settings - Fork 3k
Update to LWIP 2.1.2 #10353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LWIP 2.1.2 #10353
Conversation
@tymoteuszblochmobica, thank you for your changes. |
8b243a4
to
822e51f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second commit is only about "Multihoming was refactored due to new socket-interface bind implementation." ?
The commit changes lot of files (adding parameters, new functions) so not certain what is this refactor doing - would it make sense to add there more details or split ?
@0xc0170 , I think the most important reviews are still to come from @mikaleppanen , @kjbracey-arm and @SeppoTakalo . Please do not merge until at least one of them approves... Regarding the commit split, the idea was the following:
The second commit message body is "Multihoming fixed according to new LWIP implementation." Perhaps this should become the title of the commit message instead of just being its body? |
👍
Could be. Let other reviewers look at this as well |
822e51f
to
3512caa
Compare
Looks OK. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Info: This PR has now been rebased. Travis CI did not want to start, so I gave the PR an updated sha to generate the webhook. |
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Exporters restarted - internal symlink error |
Description
Latest LWIP 2.1.2 with necessary patches integrated with MbebOS
Pull request type
Reviewers
@SeppoTakalo
@mikaleppanen
@kjbracey-arm
Release Notes
Latest LWIP 2.1.2 released is now integrated with MbedOS.
New LWIP release has improvements in following areas:
-IP4 routing
-IP6 scopes and zones
-dhcp6
-nd6
-tcp
-Sockets
-Binding network interfaces to sockets
LWIP changelog contains detailed changes
MbedOS dedicated patches were applied to new LWIP.
Multihoming was refactored due to new socket-interface bind implementation.