Skip to content

Refactor PSA code generators #10364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2019
Merged

Refactor PSA code generators #10364

merged 1 commit into from
Apr 12, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Apr 10, 2019

Description

  • Unify PSA generators
  • Replace scanning for mbed_spm templates with json
  • Make generate_source_files and parse_manifests common
  • Make assert_int an internal function
  • Use parse_manifests in pytests
  • Update docs

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Refactor PSA code generators
ae4341e 
* Unify PSA generators
* Replace scanning for mbed_spm templates with json
* Make generate_source_files and parse_manifests common
* Make assert_int an internal function
* Use parse_manifests in pytests
* Update docs
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2019

Refactor from #10286 , will just need @ARMmbed/mbed-os-maintainers review and CI (already reviewed by @alzix )

@ciarmcom ciarmcom requested review from a team April 10, 2019 13:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested review from alzix and removed request for a team April 10, 2019 13:04
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2019

Refactor from #10286 , will just need @ARMmbed/mbed-os-maintainers review and CI (already reviewed by @alzix )

Ready for integration

alzix
alzix approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@alzix alzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmonr cmonr merged commit 2641fb3 into ARMmbed:master Apr 12, 2019
@adbridge
Copy link
Contributor

adbridge commented May 3, 2019

This is essential for a customer for 5.12.3 so retargetting to this release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzix alzix alzix approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@orenc17 @0xc0170 @ciarmcom @mbed-ci @adbridge @alzix @cmonr