ARM MPS2: Cortex-M4 -> M4F & M7 -> M7FD #10386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChangwuShan Can you review? We discussed some FPU issues related to these targets. |
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
Apr 15, 2019
|
CI started |
|
Looks ok on my side. |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage |
|
restarted jenkins-ci/greentea-test |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
According to their cmsis.h, FPU is present, so change targets.json to use it. * ARM_MPS2_M4: already was Cortex-M4F * ARM_MPS2_M7: Cortex-M7 -> M7FD * FVP_MPS2_M4: Cortex-M4 -> M4F * FVP_MPS2_M7: Cortex-M7 -> M7FD If they do not in fact have FPU, then cmsis.h should be modified to set `__FPU_PRESENT` to 0. This will currently cause compilation problems with ARMC6, but I'll be submitting a fix for that.
|
Rebased. |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@jamesbeyond Quick review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to their cmsis.h, FPU is present, so change targets.json to use it.
If they do not in fact have FPU, then cmsis.h should be modified to set
__FPU_PRESENTto 0. This will currently cause compilation problems with ARMC6, but I'll be submitting a fix for that.Pull request type