Skip to content

Networking: Fix some ARMC6 warnings #10394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Networking: Fix some ARMC6 warnings #10394

merged 1 commit into from
Apr 18, 2019
+16 −12

Conversation

kjbracey
Copy link
Contributor

Description

Some int-versus-long and signed-versus-unsigned format string mismatches, and missing class keyword.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team April 12, 2019 15:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

#10395 - also in CI, if this one completes, we can merge this one as 10395 was already approved

@kjbracey kjbracey force-pushed the networking_warnings branch from 87fe8f9 to 7fb9ae6 Compare April 15, 2019 07:45
@kjbracey
Copy link
Contributor Author

Just force pushed this to remove the stray "left shift" extra commit without reading any of the comments... Guess you were intending to merge that, making it a combo with #10395?

I can push it back to where it was, if that satisfies the CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

Lets leave it as it is, restarting CI now

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2019

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@alekla01
Copy link
Contributor

Restarted CI

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_exporter

@alekla01
Copy link
Contributor

restarted restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2019

Exporters error looks related - esp driver fails to build

@kjbracey kjbracey force-pushed the networking_warnings branch from 7fb9ae6 to 0bc5008 Compare April 16, 2019 12:06
@kjbracey
Copy link
Contributor Author

Needed to include <inttypes.h> - added.

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@kjbracey
Networking: Fix some ARMC6 warnings
69c6cc3 
Some int-versus-long and signed-versus-unsigned format string
mismatches, and missing `class` keyword.
@kjbracey kjbracey force-pushed the networking_warnings branch from 0bc5008 to 69c6cc3 Compare April 17, 2019 13:04
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2019

Will restart tests, seems like something happened to few targets (not related)

@0xc0170 0xc0170 merged commit 7392d51 into ARMmbed:master Apr 18, 2019
@kjbracey kjbracey deleted the networking_warnings branch April 18, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kjbracey @ciarmcom @0xc0170 @mbed-ci @alekla01 @VeijoPesonen