Cellular: send disconnect to correct ctx #10402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
approved these changes
Apr 15, 2019
|
@jarvte, thank you for your changes. |
AriParkkila
approved these changes
Apr 16, 2019
This was referenced Apr 16, 2019
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Disconnect was sent to all CellularContext classes even it concerned one specific context. Some disconnect events are still sent to all context classes. These event are coming from network and ment for all context classes or event did not specify cid.
jarvte
force-pushed
the
disconnect_per_context
branch
from
24d6246 to
9d67a8b
Compare
|
rebased with master to resolve conficts |
0xc0170
approved these changes
Apr 17, 2019
|
ping |
mirelachirica
approved these changes
Apr 23, 2019
|
@ARMmbed/mbed-os-maintainers could you please run CI for this pr? We need this for further development. |
|
ci started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
@adbridge I guess failure is not related to this pr. |
|
Failure looks like an ARMCC6 licence checkout issue - restarted |
|
@adbridge still failing with exporter |
|
exporters restarted again |
|
This is sitting on top of changes targeting 5.13 so bumping this out also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disconnect was sent to all CellularContext classes even it concerned one specific context. Some disconnect events are still sent to all context classes. These event are coming from network and ment for all context classes or event did not specify cid.
Pull request type
Reviewers
@AriParkkila
Release Notes