Modify CMSIS pack manager to properly handle OSError #10406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridadan
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Thanks! For extra context, this OSError occurs when you are using 64-bit Python on Windows. This fix allows you to compile and use the tools on that version. The only thing you can't do is regenerate the pack index, which is only really used during device porting.
0xc0170
approved these changes
Apr 16, 2019
cmonr
approved these changes
Apr 16, 2019
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
test restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the Arm CMSIS pack manager Python script to properly handle OSError.
Pull request type